Conversation
matsl
commented
Jun 13, 2022
test/demo-tests.el
Outdated
| (action-key) | ||
| (hy-test-helpers:consume-input-events) | ||
| (with-current-buffer shell-buffer-name | ||
| (sit-for 0.5) |
Collaborator
Author
There was a problem hiding this comment.
Maybe there is some smarter way to wait for shell output!? Same goes for the other test cases.
Collaborator
Author
There was a problem hiding this comment.
Thanks for the suggestion. The PR is now updated.
rswgnu
requested changes
Jun 13, 2022
Owner
rswgnu
left a comment
rswgnu
left a comment
There was a problem hiding this comment.
See: https://www.gnu.org/software/emacs/manual/html_node/elisp/Accepting-Output.html
See if that will work for you.
Bob
rswgnu
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tests for shell related key series examples in the fast demo.
Why
Completes the tests for key series examples in the fast demo.