Skip to content

Don't byte compile test packages with external test dependencies #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matsl merged 1 commit into from
May 22, 2022
Merged

Don't byte compile test packages with external test dependencies #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
2022-05-22 Mats Lidell <matsl@gnu.org>

* test/kexport-tests.el:
test/hmouse-info-tests.el:
test/hmouse-drv-tests.el:
test/hbut-tests.el: Don't byte compile of test files that depend on
external test support packages.

2022-05-16 Bob Weiner <rsw@gnu.org>

* FAST-DEMO: Change from /usr/bin/bash to /bin/bash.
Expand Down
11 changes: 6 additions & 5 deletions test/hbut-tests.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
;; Author: Mats Lidell <matsl@gnu.org>
;;
;; Orig-Date: 30-may-21 at 09:33:00
;; Last-Mod: 24-Jan-22 at 00:38:20 by Bob Weiner
;; Last-Mod: 22-May-22 at 10:57:31 by Mats Lidell
;;
;; Copyright (C) 2021-2022 Free Software Foundation, Inc.
;; See the "HY-COPY" file for license information.
Expand Down Expand Up @@ -170,10 +170,11 @@ Needed since hyperbole expands all links to absolute paths and
(hy-test-helpers-verify-hattr-at-p :actype 'actypes::link-to-file-line-and-column :args (list test-file 2 3) :loc test-file :lbl-key "label"))
(delete-file test-file))))

;; FIXME: This file can only be byte-compiled when `el-mock' is installed.
;; Local Variables:
;; no-byte-compile: t
;; End:
;; This file can't be byte-compiled without the `el-mock' package (because of
;; the use of the `with-mock' macro), which is not a dependency of Hyperbole.
;; Local Variables:
;; no-byte-compile: t
;; End:

(provide 'hbut-tests)
;;; hbut-tests.el ends here
9 changes: 6 additions & 3 deletions test/hmouse-drv-tests.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
;; Author: Mats Lidell <matsl@gnu.org>
;;
;; Orig-Date: 28-Feb-21 at 22:52:00
;; Last-Mod: 15-May-22 at 23:42:24 by Bob Weiner
;; Last-Mod: 22-May-22 at 11:13:48 by Mats Lidell
;;
;; Copyright (C) 2021-2022 Free Software Foundation, Inc.
;; See the "HY-COPY" file for license information.
Expand All @@ -20,6 +20,7 @@
(require 'ert)
(require 'hbut)
(require 'el-mock)
(require 'with-simulated-input)
(require 'hy-test-helpers "test/hy-test-helpers")

(ert-deftest hbut-defal ()
Expand Down Expand Up @@ -519,8 +520,10 @@ Regression: Looked up path name '-narrow'."
(action-key)))
(delete-file el-file))))

;; This file can't be byte-compiled without the `el-mock' package (because of
;; the use of the `with-mock' macro), which is not a dependency of Hyperbole.
;; This file can't be byte-compiled without the `el-mock' and
;; `with-simulated-input' package (because of the use of the
;; `with-mock' and `with-simulated-input' macro), which is not a
;; dependency of Hyperbole.
;; Local Variables:
;; no-byte-compile: t
;; End:
Expand Down
12 changes: 7 additions & 5 deletions test/hmouse-info-tests.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
;; Author: Mats Lidell <matsl@gnu.org>
;;
;; Orig-Date: 29-Dec-21 at 09:02:00
;; Last-Mod: 24-Jan-22 at 00:39:27 by Bob Weiner
;; Last-Mod: 22-May-22 at 11:11:53 by Mats Lidell
;;
;; Copyright (C) 2021-2022 Free Software Foundation, Inc.
;; See the "HY-COPY" file for license information.
Expand Down Expand Up @@ -44,10 +44,12 @@
(should (string-prefix-p "regexp" m t))))
(kill-buffer "*info*")))

;; FIXME: Can't compile when `with-simulated-input' is absent!
;; Local Variables:
;; no-byte-compile: t
;; End:
;; This file can't be byte-compiled without the `with-simulated-input'
;; package (because of the use of the `with-simulated-input' macro),
;; which is not a dependency of Hyperbole.
;; Local Variables:
;; no-byte-compile: t
;; End:

(provide 'hmouse-info-tests)
;;; hmouse-info-tests.el ends here
8 changes: 7 additions & 1 deletion test/kexport-tests.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
;; Author: Mats Lidell <matsl@gnu.org>
;;
;; Orig-Date: 10-Oct-21 at 17:30:00
;; Last-Mod: 1-Mar-22 at 23:23:49 by Mats Lidell
;; Last-Mod: 22-May-22 at 10:57:14 by Mats Lidell
;;
;; Copyright (C) 2021-2022 Free Software Foundation, Inc.
;; See the "HY-COPY" file for license information.
Expand Down Expand Up @@ -139,5 +139,11 @@
(progn
(delete-file kotl-file)))))

;; This file can't be byte-compiled without the `el-mock' package (because of
;; the use of the `with-mock' macro), which is not a dependency of Hyperbole.
;; Local Variables:
;; no-byte-compile: t
;; End:

(provide 'kexport-tests)
;;; kexport-tests.el ends here