reworks multiplexer and improves tests to check async interceptors #909 #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
OlegDokuka
force-pushed
the
bugfix/multiplexer-rework
branch
5 times, most recently
from
93297b3 to
ba5ee1c
Compare
Signed-off-by: Oleh Dokuka <[email protected]>
OlegDokuka
force-pushed
the
bugfix/multiplexer-rework
branch
from
ba5ee1c to
88079e4
Compare
OlegDokuka
changed the title
OlegDokuka
added a commit
that referenced
this pull request
Aug 7, 2020
Signed-off-by: Oleh Dokuka <[email protected]>
OlegDokuka
added a commit
that referenced
this pull request
Aug 7, 2020
Signed-off-by: Oleh Dokuka <[email protected]>
OlegDokuka
added a commit
that referenced
this pull request
Aug 7, 2020
Signed-off-by: Oleh Dokuka <[email protected]>
OlegDokuka
added a commit
that referenced
this pull request
Aug 7, 2020
Signed-off-by: Oleh Dokuka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks
ClientServerInputMultiplexerto avoid async enqueueing/dequeuing of the incoming frames when interceptors offload subscription/publication on the differentScheduler, so frame appears released at the time of its consumption (FluxReceiversendsByteBufand releases it onceonNextis returned -> https://github.com/reactor/reactor-netty/blob/master/reactor-netty-core/src/main/java/reactor/netty/channel/FluxReceive.java#L264).Basically this PR gets rid of
groupByoperator in favor of its drain-free version.FYI. This PR as well as changes related to refCoutning mechanics brake resumability.
It can wait since there is no usage of this feature in Spring-Messaging, though we should revise the whole resumability implementation before the final 1.1 release.
Signed-off-by: Oleh Dokuka [email protected]