provides ordered stream id issuing #811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegDokuka
force-pushed
the
bugfix/streamId-order
branch
from
98bbcd6 to
6a74390
Compare
rstoyanchev
requested changes
May 4, 2020
Contributor
There was a problem hiding this comment.
I'm wondering about the performance impact of putting this on the EventLoop scheduler and also whether serial execution would be enforced across multiple connections with global resources in Reactor Netty?
On other hand why not create Schedulers.single(Schedulers.parallel()) in RSocketRequester and not involve DuplexConnection at all?
Member
Author
|
I guess you are right. We can sacrifice a new API method in favor of just solving the problem |
OlegDokuka
force-pushed
the
bugfix/streamId-order
branch
from
6a74390 to
7461326
Compare
Member
Author
|
@rstoyanchev fixed. Followed your suggestion to use |
OlegDokuka
force-pushed
the
bugfix/streamId-order
branch
from
7461326 to
dcd413b
Compare
Signed-off-by: Oleh Dokuka <[email protected]>
OlegDokuka
force-pushed
the
bugfix/streamId-order
branch
from
dcd413b to
de75f44
Compare
rstoyanchev
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that stream ids are issued in order even under high racing between logical streams in the way of scheduling stream id issuing on the event loop scheduler.
This is done on the level of RSocket because of the incorrect Transport level design and should be considered as a workaround until DuplexConnection will be revised in 1.1
Signed-off-by: Oleh Dokuka [email protected]