Skip to content

Contended CAS on every buffer allocation #13

@ghost

Description

  • Originally, pre open-sourcing, the code used folly::Singleton::try_get, which is not available in the latest stable version of folly and incurs a contended CAS on every buffer allocation.
  • This have been replaced with folly::Singleton::get to fix build, but that change broke tests (why?) when compiling with CMake.
  • Once replaced back with get_weak().lock(), we again have a contended CAS on buffer allocation path. * For this reason, I'd vote to get rid of Singleton hack and inject a Singleton instance into frame serialisers.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions