Skip to content

basic support for prepared statements#18

Open
marctrem wants to merge 3 commits intorqlite:masterfrom
marctrem:execute-argument-support
Open

basic support for prepared statements#18
marctrem wants to merge 3 commits intorqlite:masterfrom
marctrem:execute-argument-support

Conversation

@marctrem
Copy link

Please let me know if you like this so I can polish it.

@marctrem marctrem force-pushed the execute-argument-support branch from 8e71f91 to 849972b Compare July 21, 2021 00:24
@marctrem marctrem force-pushed the execute-argument-support branch from 849972b to 54f6849 Compare July 21, 2021 00:25
@otoolep
Copy link
Member

otoolep commented Jul 21, 2021

Yes, thanks -- this functionality is definitely welcome.

@marctrem marctrem marked this pull request as ready for review July 21, 2021 01:51
@otoolep
Copy link
Member

otoolep commented Sep 13, 2022

The original author indicated there would be more "polish" to come, so I didn't merge it yet. I would need to examine the code, and determine if it's ready for merging (and that sufficient testing has been put in place).

Is there anyone interested in doing that?

@sgalsaleh
Copy link
Collaborator

@otoolep It looks like the author has marked the PR as "ready for review", so I assume that the polishing is done? I can also see that tests have been added. I'm not sure if the author is still active, but if further changes need to me made, I'd be happy to make them and submit a separate PR.

@gandaldf
Copy link

If you want, take a look at my repo: https://github.com/gandaldf/gorqlite

@sgalsaleh
Copy link
Collaborator

@gandaldf thank you for the suggestion, I'm about to submit a PR soon of my own with support for both parameterized statements and nullable types. If you're interested, this is how it looks like now: https://github.com/replicatedhq/gorqlite/pull/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants