Conversation
8e71f91 to
849972b
Compare
849972b to
54f6849
Compare
|
Yes, thanks -- this functionality is definitely welcome. |
|
The original author indicated there would be more "polish" to come, so I didn't merge it yet. I would need to examine the code, and determine if it's ready for merging (and that sufficient testing has been put in place). Is there anyone interested in doing that? |
|
@otoolep It looks like the author has marked the PR as "ready for review", so I assume that the polishing is done? I can also see that tests have been added. I'm not sure if the author is still active, but if further changes need to me made, I'd be happy to make them and submit a separate PR. |
|
If you want, take a look at my repo: https://github.com/gandaldf/gorqlite |
|
@gandaldf thank you for the suggestion, I'm about to submit a PR soon of my own with support for both parameterized statements and nullable types. If you're interested, this is how it looks like now: https://github.com/replicatedhq/gorqlite/pull/1 |
Please let me know if you like this so I can polish it.