This repository was archived by the owner on May 31, 2025. It is now read-only.
Added gennodejs message generation #4
Closed
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanTheEngineer
changed the title
Contributor
Author
|
I am updating this pull request to reflect the name change for the Javascript message generation package from |
IanTheEngineer
force-pushed
the
add_rosjs
branch
from
d85fb05 to
daeeb6e
Compare
IanTheEngineer
force-pushed
the
add_rosjs
branch
from
daeeb6e to
9efb716
Compare
8 tasks
Member
|
I created a new branch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the dependency of
gennodejsto message generation to force the buildfarm. I am not sure this is strictly necessary, ascatkin_makeandcatkin_make installrun in a developer's workspace will both generate and deploy the messages as expected (without needing to explicitly patchmessage_generation).However, as of last night's build,
shadow-fixedhad thegennodejspackage in it, but did not generate any messages. Is there any way to test that this change tomessage_generationwill have the desired effect of rebuilding all ROS messages for Javascript?