Use PyQt5 module path to find SIP bindings (ROS 2) #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cottsay
approved these changes
Nov 5, 2021
Member
cottsay
left a comment
cottsay
left a comment
There was a problem hiding this comment.
This worked for me on Fedora 35. Thanks!
`sipconfig._pkg_config['default_mod_dir']` is currently used to find the PyQt5 SIP bindings, but this location is determined by where SIP is installed, which may not be the same as where PyQt5 is installed. A real world example of this is in Nix, where each package is installed to a separate isolated directory. Instead, we can use `PyQt5.__path__[0]`, which will always point to the location of the PyQt5 module.
clalancette
force-pushed
the
pyqt5-sip5-ros2
branch
from
3ad5e2a to
fb4ef9b
Compare
Contributor
|
CI:
|
clalancette
approved these changes
Nov 19, 2021
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
This also works for me on Ubuntu 22.04. Thanks!
Contributor
|
All of the failing tests are in the nightlies as well, so not added by this PR. I'm going to go ahead and merge this, thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies #95 and #105 to the main branch to be included in a ROS 2 release.