[WIP] Add FastLZMA2 compression algorithm by oshadura · Pull Request #7615 · root-project/root

oshadura · 2021-03-19T15:59:23Z

No description provided.

phsft-bot · 2021-03-19T15:59:31Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-03-19T15:59:48Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on null:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

[2021-03-19T15:59:47.320Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:16 (_find_package):
[2021-03-19T15:59:47.320Z] CMake Error at /data/sftnight/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1093 (message):

phsft-bot · 2021-03-19T16:01:09Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-03-19T16:01:08.653Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:16 (_find_package):
[2021-03-19T16:01:08.653Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1093 (message):

phsft-bot · 2021-03-19T16:01:11Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-03-19T16:01:09.952Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:16 (_find_package):
[2021-03-19T16:01:09.952Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1093 (message):

phsft-bot · 2021-03-19T16:01:25Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-03-19T16:01:23.922Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:16 (_find_package):
[2021-03-19T16:01:23.922Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1093 (message):

phsft-bot · 2021-03-19T16:01:59Z

Build failed on mac1014/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-03-19T16:01:58.500Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:16 (_find_package):
[2021-03-19T16:01:58.500Z] CMake Error at /Volumes/HD2/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1093 (message):

ghost · 2021-03-19T16:02:09Z

DeepCode's analysis on #187ec0 found:

⚠️ 1 warning, ℹ️ 1 minor issue. 👇

Top issues

Description	Example fixes
Potential nullptr dereference. 0 may return a nullptr if malloc failed to allocate memory. Consider adding a check for nullness. Occurrences: fl2_decompress.c:558 fl2_decompress.c:559	🔧 Example fixes
Numerical operation plus used with boolean operand not. Consider making the conversion from bool to integer explicit. Occurrences: radix_mf.c:226	🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

phsft-bot · 2021-03-19T16:04:39Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-03-19T16:04:37.972Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:16 (_find_package):
[2021-03-19T16:04:37.972Z] CMake Error at /mnt/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1093 (message):

phsft-bot · 2021-03-19T16:56:52Z

Build failed on mac11.0/cxx17.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

[2021-03-19T16:56:51.221Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:16 (_find_package):
[2021-03-19T16:56:51.221Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1093 (message):

phsft-bot · 2021-03-19T17:36:31Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2021-03-19T17:36:30.064Z] CMake Error at cmake/modules/SearchInstalledSoftware.cmake:16 (_find_package):
[2021-03-19T17:36:30.064Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1093 (message):

phsft-bot · 2021-03-21T14:36:52Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-03-21T14:40:09Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-03-21T14:51:13Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-03-21T15:10:38Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2021-03-21T14:52:16.452Z] /home/sftnight/build/workspace/root-pullrequests-build/root/builtins/flzma2/fl2_compress.c:584:25: warning: comparison of integer expressions of different signedness: ‘long int’ and ‘long unsigned int’ [-Wsign-compare]

phsft-bot · 2021-03-21T15:15:02Z

Build failed on ROOT-performance-centos8-multicore/default.
Running on null:/data/sftnight/workspace/root-pullrequests-build
See console output.

Warnings:

[2021-03-21T14:51:59.659Z] /data/sftnight/workspace/root-pullrequests-build/root/builtins/flzma2/fl2_compress.c:584:25: warning: comparison of integer expressions of different signedness: ‘long int’ and ‘long unsigned int’ [-Wsign-compare]

phsft-bot · 2021-03-21T15:21:08Z

Build failed on ROOT-fedora30/cxx14.
Running on root-fedora30-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2021-03-21T14:52:36.333Z] /home/sftnight/build/workspace/root-pullrequests-build/root/builtins/flzma2/fl2_compress.c:584:25: warning: comparison of integer expressions of different signedness: ‘long int’ and ‘long unsigned int’ [-Wsign-compare]

phsft-bot · 2021-03-21T15:33:06Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-1.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2021-03-21T14:53:37.324Z] /mnt/build/workspace/root-pullrequests-build/root/builtins/flzma2/fl2_compress.c:584:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

phsft-bot · 2021-03-21T15:48:37Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

[2021-03-21T15:47:26.319Z] C:\build\workspace\root-pullrequests-build\root\roofit\RDataFrameHelpers\test\testActionHelpers.cxx(22,73): error C3493: 'nEvent' cannot be implicitly captured because no default capture mode has been specified [C:\build\workspace\root-pullrequests-build\build\roofit\RDataFrameHelpers\test\testActionHelpers.vcxproj]
[2021-03-21T15:47:26.319Z] C:\build\workspace\root-pullrequests-build\root\roofit\RDataFrameHelpers\test\testActionHelpers.cxx(23,73): error C3493: 'nEvent' cannot be implicitly captured because no default capture mode has been specified [C:\build\workspace\root-pullrequests-build\build\roofit\RDataFrameHelpers\test\testActionHelpers.vcxproj]

phsft-bot · 2021-03-21T16:14:54Z

Build failed on mac11.0/cxx17.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2021-03-21T15:07:23.543Z] /Users/sftnight/build/workspace/root-pullrequests-build/root/builtins/flzma2/fl2_compress.c:584:25: warning: comparison of integers of different signs: 'long' and 'unsigned long' [-Wsign-compare]

phsft-bot · 2021-03-21T16:18:49Z

Build failed on mac1014/python3.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2021-03-21T15:00:09.544Z] /Volumes/HD2/build/workspace/root-pullrequests-build/root/builtins/flzma2/fl2_compress.c:584:25: warning: comparison of integers of different signs: 'long' and 'unsigned long' [-Wsign-compare]

phsft-bot · 2021-03-21T16:22:55Z

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2021-03-21T14:54:04.328Z] /home/sftnight/build/workspace/root-pullrequests-build/root/builtins/flzma2/fl2_compress.c:584:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
[2021-03-21T14:54:09.577Z] /home/sftnight/build/workspace/root-pullrequests-build/root/builtins/flzma2/lzma2_enc.c:909:97: warning: operand of ?: changes signedness from ‘ptrdiff_t’ {aka ‘const int’} to ‘U32’ {aka ‘const unsigned int’} due to unsignedness of other operand [-Wsign-compare]

phsft-bot · 2021-03-22T09:58:50Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-03-22T10:29:11Z

Build failed on ROOT-fedora31/noimt.
Running on root-fedora-31-2.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2021-03-22T10:15:34.898Z] /home/sftnight/build/workspace/root-pullrequests-build/root/builtins/flzma2/fl2_compress.c:584:12: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
[2021-03-22T10:15:34.898Z] /home/sftnight/build/workspace/root-pullrequests-build/root/builtins/flzma2/fl2_compress.c:584:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

phsft-bot · 2021-03-22T10:44:18Z

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-4.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Warnings:

[2021-03-22T10:03:54.273Z] /mnt/build/workspace/root-pullrequests-build/root/builtins/flzma2/fl2_compress.c:584:12: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
[2021-03-22T10:03:54.273Z] /mnt/build/workspace/root-pullrequests-build/root/builtins/flzma2/fl2_compress.c:584:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]

phsft-bot · 2021-03-22T11:04:12Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-03-23T13:10:25Z

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

phsft-bot · 2021-03-23T13:10:52Z

Build failed on mac11.0/cxx17.
See console output.

oshadura · 2021-05-20T09:35:55Z

Closing PR since development had been decide not to merge (see presentation https://indico.cern.ch/event/1029474/)

oshadura requested review from Axel-Naumann and pcanal as code owners March 19, 2021 15:59

oshadura changed the title ~~[WIP] Add FastLZMA2 compression algorithm~~ [skip-ci][WIP] Add FastLZMA2 compression algorithm Mar 19, 2021

oshadura force-pushed the builtin-fast-lzma2 branch 2 times, most recently from f059bc1 to 206c735 Compare March 21, 2021 14:05

oshadura mentioned this pull request Mar 21, 2021

Testing builtin fast lzma2 in ROOT root-project/rootbench#216

Closed

oshadura changed the title ~~[skip-ci][WIP] Add FastLZMA2 compression algorithm~~ [WIP] Add FastLZMA2 compression algorithm Mar 21, 2021

oshadura force-pushed the builtin-fast-lzma2 branch from 206c735 to 7c745d9 Compare March 21, 2021 14:36

oshadura force-pushed the builtin-fast-lzma2 branch from 7c745d9 to 7d0dd26 Compare March 21, 2021 14:40

root-project deleted a comment from phsft-bot Mar 21, 2021

oshadura force-pushed the builtin-fast-lzma2 branch from 7d0dd26 to c9e00f5 Compare March 21, 2021 14:51

oshadura force-pushed the builtin-fast-lzma2 branch from c9e00f5 to 30ba59d Compare March 22, 2021 09:58

Add FastLZMA2 compression algorithm

0a5b72f

oshadura force-pushed the builtin-fast-lzma2 branch from 30ba59d to 0a5b72f Compare March 22, 2021 11:04

couet assigned oshadura Mar 22, 2021

Try to decompress with LZMA something compressed with FLZMA2

187ec0c

oshadura closed this May 20, 2021

Conversation

oshadura commented Mar 19, 2021

Uh oh!

phsft-bot commented Mar 19, 2021

Uh oh!

phsft-bot commented Mar 19, 2021

Errors:

Uh oh!

phsft-bot commented Mar 19, 2021

Errors:

Uh oh!

phsft-bot commented Mar 19, 2021

Errors:

Uh oh!

phsft-bot commented Mar 19, 2021

Errors:

Uh oh!

phsft-bot commented Mar 19, 2021

Errors:

Uh oh!

ghost commented Mar 19, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepCode's analysis on #187ec0 found:

Top issues

👉 View analysis in DeepCode’s Dashboard | Configure the bot

Uh oh!

phsft-bot commented Mar 19, 2021

Errors:

Uh oh!

phsft-bot commented Mar 19, 2021

Errors:

Uh oh!

phsft-bot commented Mar 19, 2021

Errors:

Uh oh!

phsft-bot commented Mar 21, 2021

Uh oh!

phsft-bot commented Mar 21, 2021

Uh oh!

phsft-bot commented Mar 21, 2021

Uh oh!

phsft-bot commented Mar 21, 2021

Warnings:

Uh oh!

phsft-bot commented Mar 21, 2021

Warnings:

Uh oh!

phsft-bot commented Mar 21, 2021

Warnings:

Uh oh!

phsft-bot commented Mar 21, 2021

Warnings:

Uh oh!

phsft-bot commented Mar 21, 2021

Errors:

Uh oh!

phsft-bot commented Mar 21, 2021

Warnings:

Uh oh!

phsft-bot commented Mar 21, 2021

Warnings:

Uh oh!

phsft-bot commented Mar 21, 2021

Warnings:

Uh oh!

phsft-bot commented Mar 22, 2021

Uh oh!

phsft-bot commented Mar 22, 2021

Warnings:

Uh oh!

phsft-bot commented Mar 22, 2021

Warnings:

Uh oh!

phsft-bot commented Mar 22, 2021

Uh oh!

phsft-bot commented Mar 23, 2021

Uh oh!

phsft-bot commented Mar 23, 2021

Uh oh!

oshadura commented May 20, 2021

ghost commented Mar 19, 2021 •

edited by ghost

Loading