[Python] Clear TList in tseqcollection_itemaccess.py:test_delitem#21532
Merged
guitargeek merged 1 commit intoroot-project:masterfrom Mar 8, 2026
Merged
[Python] Clear TList in tseqcollection_itemaccess.py:test_delitem#21532guitargeek merged 1 commit intoroot-project:masterfrom
guitargeek merged 1 commit intoroot-project:masterfrom
Conversation
Clear the TList at the end of the `test_delitem` unit test in tseqcollection_itemaccess.py to make sure the contained list elements are still alive when the list is cleared. Otherwise, the elements might be deleted before the containing list, depending on the order or garbage collection.
Test Results 22 files 22 suites 3d 11h 2m 58s ⏱️ Results for commit 3828280. |
vepadulano
approved these changes
Mar 8, 2026
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
I'm starting to think we should deprecate TList for Python usage at least in docs :)
Contributor
Author
|
Absolutely agreed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear the TList at the end of the
test_delitemunit test in tseqcollection_itemaccess.py to make sure the contained list elements are still alive when the list is cleared. Otherwise, the elements might be deleted before the containing list, depending on the order or garbage collection.Spinoff from #13593