Restore HTML menu max length, but as an optional feature and improved the trimming with HTML banners#758
Closed
Dliix66 wants to merge 2 commits intoroflmuffin:mainfrom
Closed
Conversation
Owner
|
Not sure this should really be a core config, given that the plugin author themselves would not be able to predict the behaviour of their menu based on this setting. If this is a desired functionality of the menu, I think it should be opt-in by the plugin author when they create the menu, rather than it coming from CSS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is following #747
It adds the ability to enable or disable the limit. But it also improves the trimming by not taking HTML banners into account, but it also closes the open banners after trimming to avoid any visual issues.
Example:
"Hello World! This is a test." trimmed to 8 characters will be "Hello Wo"
To do this, add this in your config:
"MaxHtmlMenuTitleLength": 0, // 0 = unlimited, previous value = 32
"MaxHtmlMenuOptionLength": 0, // 0 = unlimited, previous value = 26`