Skip to content

Conversation

@spatecon
Copy link

@spatecon spatecon commented May 8, 2025

Fixes #347

I've decided not to decouple apiJobToJob as we use it for both getJob and listJobs for now. So simple check for empty (non-present) errors array is enough.

Works just fine.

@bgentry
Copy link
Contributor

bgentry commented May 8, 2025

Hey, thank you for catching this and for proposing a fix! Ultimately the issue is that I forgot to update the typescript types to reflect the backend changes, so the proper fix is a little more involved than this PR. I've made those changes in #349.

Given this was an unreleased commit, meanwhile you should be able to just use the previous commit to use the new job list filters without the changes that caused this breakage. Fixes should be merged soon anyway though. Got a few more items to get in before an official UI release, should be in the next few days at most!

@bgentry bgentry closed this May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jobs List page crushed: AttemptErrors not present in response

3 participants