Remove straggler references to advisory locks for uniqueness#40
Merged
Remove straggler references to advisory locks for uniqueness#40
Conversation
Remove a few straggler references saying that advisory locks provide uniqueness. As of #28, this is no longer true and a unique index is used instead.
brandur
commented
Feb 27, 2025
| # doing a look up for an equivalent row, and inserting only if none was found. | ||
| # There's no database-level mechanism that guarantees jobs stay unique, so if | ||
| # an equivalent row is inserted out of band (or batch inserted, where a unique | ||
| # check doesn't occur), it's conceivable that duplicates could coexist. |
Contributor
Author
There was a problem hiding this comment.
I could've changed this to talk about unique_key, but the paragraph was essentially a block warning not to insert unique jobs out of band, so felt like it wasn't really needed anymore.
bgentry
approved these changes
Feb 27, 2025
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove a few straggler references saying that advisory locks provide
uniqueness. As of #28, this is no longer true and a unique index is used
instead.