Fix intermittent test in sqlctemplate relating to arbitrary map sorting
#796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting Here, fix an intermittent test [1] that's come up _already_ since #795 was merged in. This is a problem that gets me a lot, which is that map sorting in Go is not guaranteed, despite in tests small maps often coming out in the order that you're looking for so you don't notice a problem until later. Here, when processing named args in a template, walk through them in alphabetical order. This has no meaningful effect on the rendered SQL, but provides stability for the test suite. [1] https://github.com/riverqueue/river/actions/runs/13734150171/job/38415749775?pr=795
bgentry
approved these changes
Mar 8, 2025
Contributor
bgentry
left a comment
bgentry
left a comment
There was a problem hiding this comment.
Fun fact. In an interview years ago I couldn't recall how to randomly shuffle a slice and wasn't supposed to look things up, so I made it work by relying on a map for a weak pseudo-random sort 😆
Contributor
Author
LOL!!! A+ Go deep cut rating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, fix an intermittent test [1] that's come up already since #795
was merged in. This is a problem that gets me a lot, which is that map
sorting in Go is not guaranteed, despite in tests small maps often
coming out in the order that you're looking for so you don't notice a
problem until later.
Here, when processing named args in a template, walk through them in
alphabetical order. This has no meaningful effect on the rendered SQL,
but provides stability for the test suite.
[1] https://github.com/riverqueue/river/actions/runs/13734150171/job/38415749775?pr=795