Add test case checking for snoozed event kind on zero duration snooze #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick follow up to add regression coverage for #1057. We already had a test case in there that checks for snooze events being emitted on a more normal snooze with non-zero snooze duration, but the problem being fixed only occurs on zero duration snoozes. Here, add one more test case that covers that as well. I also looked into extracting the event-kind-from-job-completer-result logic so that it could be shared between client and test worker and prevent this sort of problem down the line, but it's unfortunately made quite difficult because `river.EventKind*` lives in `river` instead of `rivertype`, which means that it can't be referenced without making the top-level `river` a dependency. And if `river` becomes a dependency, a cyclic dependency is introduced. Also added a changelog for #1057.
bgentry
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick follow up to add regression coverage for #1057. We already had a
test case in there that checks for snooze events being emitted on a more
normal snooze with non-zero snooze duration, but the problem being fixed
only occurs on zero duration snoozes. Here, add one more test case that
covers that as well.
I also looked into extracting the event-kind-from-job-completer-result
logic so that it could be shared between client and test worker and
prevent this sort of problem down the line, but it's unfortunately made
quite difficult because
river.EventKind*lives inriverinstead ofrivertype, which means that it can't be referenced without making thetop-level
rivera dependency. And ifriverbecomes a dependency, acyclic dependency is introduced.
Also added a changelog for #1057.