DOC-1587 Conditionalize Manage Throughput for Cloud#1309
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughAdds AsciiDoc single-source region markers to modules/manage/pages/cluster-maintenance/manage-throughput.adoc: inserts // tag::single-source[] near the top (after page-categories) and // end::single-source[] at the end. No content edits, feature changes, or behavior modifications. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Assessment against linked issues
Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
modules/manage/pages/cluster-maintenance/manage-throughput.adoc (1)
4-4: No downstream includes found; tag block is balanced
- Search for
include::…manage-throughput.adocreturned no hits—this region isn’t currently reused.- The
// tag::single-source[]/// end::single-source[]block is correctly balanced (1 start, 1 end).- When you do include this file in the future, be sure to add
tags=single-sourceto scope the snippet.- If you later need only a subset of this content (e.g., excluding broker-wide cluster-config sections), introduce nested tag blocks for finer granularity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these settings in your CodeRabbit configuration.
📒 Files selected for processing (1)
modules/manage/pages/cluster-maintenance/manage-throughput.adoc(2 hunks)
🔇 Additional comments (2)
modules/manage/pages/cluster-maintenance/manage-throughput.adoc (2)
4-4: Start tag correctly scopes reusable body contentPlacing the tag after the title and page attributes is appropriate for single-sourcing only the body content without leaking page-level metadata into includes.
246-246: Closing tag matches and cleanly wraps the intended regionThe region is properly terminated; no block/tables are left unterminated at the boundary.
|
@mattschumpert do you want this added to the Cloud What's New? |
|
Sure, Martin said it's not love in production yet but I guess it will be Tuesday ? |
I'll add to What's New & wait to merge until @weeco's approval |
We missed the release train, we got the okay to merge too late. But managing is not possible, just viewing client quotas. I'm not a SME for cluster quotas. |
kbatuigas
left a comment
There was a problem hiding this comment.
No blockers, just minor suggestions
modules/manage/pages/cluster-maintenance/manage-throughput.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Kat Batuigas <36839689+kbatuigas@users.noreply.github.com>
Description
This pull request makes
rpk cluster quotascommands + the Manage Throughput file single-sourceable to cloud-docs and conditionalizes out SM-specific properties: [1] [2]It also adds this line: You can manage client quotas with
rpk cluster quotasor with the Kafka API. (Soon, it will also be on the Quotas page in Redpanda Cloud.. but not yet). When no quotas apply, the client has unlimited throughput.Single sourcing for
cloud-docs(including What's New in Cloud) is done in redpanda-data/cloud-docs#388.Resolves https://redpandadata.atlassian.net/browse/DOC-1587
Review deadline:
Page previews
Manage Throughput in Cloud docs
Checks