Skip to content

Rpk cluster config edits#1143

Merged
kbatuigas merged 7 commits intomainfrom
DOC-1289-clarify-rpk-cluster-config-text
Jun 2, 2025
Merged

Rpk cluster config edits#1143
kbatuigas merged 7 commits intomainfrom
DOC-1289-clarify-rpk-cluster-config-text

Conversation

@kbatuigas
Copy link
Copy Markdown
Contributor

@kbatuigas kbatuigas commented May 30, 2025

Description

This pull request focuses on improving the clarity and consistency of documentation for various rpk cluster config commands in the Redpanda CLI. Key changes include rephrasing for better readability, standardizing terminology, and enhancing descriptions of command behavior and options.

Documentation Improvements:

  • General clarity and terminology updates:

    • Updated descriptions to replace "nodes" with "brokers" for consistency and clarified the distinction between cluster and broker properties in rpk-cluster-config-edit.adoc.
    • Improved phrasing in rpk-cluster-config-force-reset.adoc to emphasize the specific use case for the force-reset command and clarified its behavior.
  • Consistency in flag descriptions:

    • Standardized the description for the --all flag across rpk-cluster-config-edit.adoc and rpk-cluster-config-export.adoc to ensure uniformity in explaining low-level tunables. [1] [2]
  • Enhanced command option descriptions:

    • Refined the explanation of the --cache-file option in rpk-cluster-config-force-reset.adoc to improve clarity and align with Redpanda's terminology.
  • Additional contextual improvements:

    • Added a conditional block for cloud environments in rpk-cluster-config-get.adoc to guide users toward appropriate commands for interactive or bulk operations.
    • Reworded the description of deprecated content handling in rpk-cluster-config-lint.adoc for better readability.

Resolves https://redpandadata.atlassian.net/browse/
Review deadline:

Page previews

edit
export
get
force-reset
import
lint

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@kbatuigas kbatuigas requested a review from a team as a code owner May 30, 2025 19:51
@netlify
Copy link
Copy Markdown

netlify bot commented May 30, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 41d23fa
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/683d404e341c1b0008e85396
😎 Deploy Preview https://deploy-preview-1143--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 30, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The changes revise documentation for several rpk cluster config commands, focusing on clarifying terminology and improving phrasing. The term "node" is consistently replaced with "broker," and explanations are reworded for better clarity and precision. Notes and warnings are updated to be more explicit, and some content is conditionally included based on environment variables. No functional or procedural changes are made; all modifications are limited to wording and formatting in documentation files.

Assessment against linked issues

Objective Addressed Explanation
Clarify rpk cluster config text, especially replacing confusing node/broker terminology (DOC-1289)
Improve clarity and consistency in documentation for rpk cluster config commands (DOC-1289)
Ensure documentation reflects support for Cloud and conditionally shows relevant notes (DOC-1289)

Suggested reviewers

  • pmw-rp
  • Feediver1
  • micheleRP

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kbatuigas kbatuigas requested a review from r-vasquez May 30, 2025 19:52
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
modules/reference/pages/rpk/rpk-cluster/rpk-cluster-config-force-reset.adoc (2)

10-12: Suggest full command names for clarity
Refer to rpk cluster config set and rpk cluster config edit instead of just set/edit to avoid ambiguity in command references.


29-30: Suggest clarifying default path
“Defaults to Redpanda data directory” could be more precise by naming the actual path (e.g., /var/lib/redpanda/data) or referencing the data-directory flag.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2032aee and e35ea82.

📒 Files selected for processing (5)
  • modules/reference/pages/rpk/rpk-cluster/rpk-cluster-config-edit.adoc (1 hunks)
  • modules/reference/pages/rpk/rpk-cluster/rpk-cluster-config-export.adoc (1 hunks)
  • modules/reference/pages/rpk/rpk-cluster/rpk-cluster-config-force-reset.adoc (2 hunks)
  • modules/reference/pages/rpk/rpk-cluster/rpk-cluster-config-get.adoc (1 hunks)
  • modules/reference/pages/rpk/rpk-cluster/rpk-cluster-config-lint.adoc (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - redpanda-docs-preview
  • GitHub Check: Header rules - redpanda-docs-preview
  • GitHub Check: Pages changed - redpanda-docs-preview
🔇 Additional comments (8)
modules/reference/pages/rpk/rpk-cluster/rpk-cluster-config-lint.adoc (1)

5-6: Approve phrasing refinement
The updated sentence correctly replaces “managed via …” with “managed through …” and fixes the possessive form, improving readability without changing meaning.

modules/reference/pages/rpk/rpk-cluster/rpk-cluster-config-export.adoc (1)

9-10: Approve clearer tunables note
Splitting into two sentences cleanly separates the default exclusion from the instruction to use --all, matching the style of related docs.

modules/reference/pages/rpk/rpk-cluster/rpk-cluster-config-force-reset.adoc (3)

3-3: Approve terminology precision
Changing “on this node” to “on a broker” makes the target explicit and aligns with the updated terminology in other docs.


5-5: Approve tightened usage warning
Restricting force-reset to startup failure scenarios clarifies its intent and helps prevent misuse.


7-8: Approve cache behavior explanation
The rephrased description clearly communicates that the property is removed from the local broker cache and reverted to default on next startup.

modules/reference/pages/rpk/rpk-cluster/rpk-cluster-config-edit.adoc (3)

7-8: Approve consistent terminology
Replacing “nodes” with “brokers” and distinguishing cluster vs. broker properties aligns with the updated vocabulary across all rpk cluster config docs.


10-12: Approve streamlined save behavior description
The revised wording succinctly explains that changes are persisted when the editor is closed.


14-15: Approve unified tunables phrasing
The two-sentence approach and consistent use of “tunables” mirrors other command references (export, lint), enhancing uniformity.

Copy link
Copy Markdown
Contributor

@r-vasquez r-vasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Contributor

@micheleRP micheleRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my suggestions, then looks good!

kbatuigas and others added 2 commits June 1, 2025 22:58
@kbatuigas kbatuigas merged commit d923570 into main Jun 2, 2025
7 checks passed
@kbatuigas kbatuigas deleted the DOC-1289-clarify-rpk-cluster-config-text branch June 2, 2025 06:13
JakeSCahill pushed a commit that referenced this pull request Jul 15, 2025
Co-authored-by: Michele Cyran <michele@redpanda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants