Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe Azure BYOC cluster creation doc adds Microsoft.ContainerService to required providers, details az provider register/show commands for provider registration, introduces steps to enable and verify EncryptionAtHost, adds instructions to enable Network Watcher, extends the cluster creation flow with an optional Advanced settings section for custom tags, and expands post-creation guidance to include Azure IAM policies and tag management. Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant CLI as Azure CLI
participant ARM as Azure Resource Manager
participant RP as Redpanda Cloud
User->>CLI: az provider register/show for required providers<br/>(Compute, ManagedIdentity, Storage, KeyVault, Network, ContainerService)
CLI->>ARM: Register providers / query registration state
ARM-->>CLI: Registration status per provider
User->>CLI: az feature register --namespace Microsoft.Compute --name EncryptionAtHost
CLI->>ARM: Register feature
ARM-->>CLI: Feature state (Registered/NotRegistered)
Note over CLI,ARM: Provider refresh if needed
User->>CLI: Enable Network Watcher in target region/resource group
CLI->>ARM: Create/enable Network Watcher
ARM-->>CLI: Confirmation
User->>RP: Create BYOC cluster (Azure) via UI/flow
RP->>ARM: Provision resources in subscription
Note over RP,ARM: Optional Advanced: apply custom tags
ARM-->>RP: Provisioning status
RP-->>User: Cluster created
User->>ARM: (Optional) Apply/adjust custom tags post-creation
User->>ARM: (Post-creation) Configure IAM policies for agents
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
modules/get-started/pages/cluster-types/byoc/azure/create-byoc-cluster-azure.adoc(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - rp-cloud
- GitHub Check: Header rules - rp-cloud
- GitHub Check: Pages changed - rp-cloud
Description
This PR updates the doc for creating BYOC clusters on Azure, clarifying the required resource providers and improving instructions for registering and verifying provider status.
Microsoft.ContainerServiceto the required resource providers list.Resolves https://redpandadata.atlassian.net/browse/DOC-1716
Review deadline:
Page previews
Create a BYOC Cluster on Azure
Checks