-
Notifications
You must be signed in to change notification settings - Fork 290
K8s: User-defined modules (Asgard release) #2524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dwdougherty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments, mostly link-related.
Co-authored-by: David Dougherty <[email protected]>
Co-authored-by: David Dougherty <[email protected]>
| 3. **Verify the module manifest (`module.json`) is valid:** | ||
| Download the module zip file and check that it contains a valid `module.json` file with required fields: `module_name`, `display_name`, `semantic_version`, `commands`, and `min_redis_version`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new module version selection mechanism in RS is actually looking for compatible_redis_version instead of min_redis_version. So compatible_redis_version must exist and should match the Redis OSS version the user wants to use the module with.
Doc changes for the custom modules capability in the Asgard release