Skip to content

Conversation

@rm3l
Copy link
Member

@rm3l rm3l commented Jul 21, 2023

What type of PR is this:

What does this PR do / why we need it:
This makes sure the list is accurate, to avoid requesting PR reviews
from people no longer maintaining the project.
Ideally, I would put a GitHub team,
but this does not seem to be supported [1].
It can be done via an additional OWNERS_ALIASES file [2],
but this is yet to be tested.

[1] https://www.kubernetes.dev/docs/guide/owners/
[2] https://www.kubernetes.dev/docs/guide/owners/#owners_aliases

Which issue(s) this PR fixes:

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

This makes sure the list is accurate, to avoid requesting PR reviews
from people no longer maintaining the project.
Ideally, I would put a GitHub team,
but this does not seem to be supported [1].
It can be done via an additional OWNERS_ALIASES file [2],
but this is yet to be tested.

[1] https://www.kubernetes.dev/docs/guide/owners/
[2] https://www.kubernetes.dev/docs/guide/owners/#owners_aliases
@rm3l rm3l requested review from feloy and kadel July 21, 2023 11:49
@rm3l rm3l temporarily deployed to internal July 21, 2023 11:49 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot requested a review from anandrkskd July 21, 2023 11:49
@netlify
Copy link

netlify bot commented Jul 21, 2023

🔨 Deploy Preview deleted from internal cluster!

Name Link
🔨 Latest commit 477b2cf
😎 Deploy Preview https://odo-dev-pr-6997.odo-test-kubernete-449701-49529fc6e6a4a9fe7ebba9a3db5b55c4-0000.eu-de.containers.appdomain.cloud/

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rm3l rm3l modified the milestone: v3.13.0 🚀 Jul 21, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 21, 2023
@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@rm3l rm3l added this to the v3.13.0 🚀 milestone Jul 21, 2023
@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@openshift-merge-robot openshift-merge-robot merged commit df07ac8 into redhat-developer:main Jul 21, 2023
@openshift-merge-robot openshift-merge-robot temporarily deployed to internal July 21, 2023 12:27 — with GitHub Actions Inactive
@odo-robot
Copy link

odo-robot bot commented Jul 21, 2023

Kubernetes Docs Tests on commit fdafabe finished successfully.
View logs: TXT HTML

@rm3l rm3l deleted the cleanup_owners_files branch July 21, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants