-
Notifications
You must be signed in to change notification settings - Fork 246
Display list of commands from the local devfile in odo describe component output
#6944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
openshift-merge-robot
merged 4 commits into
redhat-developer:main
from
rm3l:6892-display-list-of-commands-from-the-local-devfile-in-odo-describe-component-output
Jul 3, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
🔨 Deploy Preview deleted from internal cluster!
|
commands from the local devfile in odo describe component outputcommands from the local devfile in odo describe component output
feloy
approved these changes
Jul 3, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/devfile-spec
Issues or PRs related to the Devfile specification and how odo handles and interprets it.
kind/feature
Categorizes issue as a feature request. For PRs, that means that the PR is the implementation
lgtm
Indicates that a PR is ready to be merged. Required by Prow.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.








What type of PR is this:
/kind feature
What does this PR do / why we need it:
This adds information about commands defined in the Devfile fro; the
odo describe componentoutput.Which issue(s) this PR fixes:
Fixes #6892
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
See #6892 for more context. When executed from a directory containing a Devfile,
odo describe componentshould now display the list of commands that are defined in the Devfile, if any.In the JSON output, this is available under a new
.devfileData.commandsfield.odo describe component -o json | jq -r '.devfileData.commands'
[ { "name": "install", "type": "exec", "group": "build", "isDefault": true, "commandLine": "npm install", "component": "runtime", "componentType": "container" }, { "name": "innerloop-pod-command", "type": "apply", "group": "test", "isDefault": false, "component": "innerloop-pod", "componentType": "kubernetes" }, { "name": "start", "type": "exec", "commandLine": "npm start", "component": "runtime", "componentType": "container" }, { "name": "run", "type": "composite", "group": "run", "isDefault": true }, { "name": "build-image", "type": "apply", "component": "prod-image", "componentType": "image", "imageName": "quay.io/tkral/devfile-nodejs-deploy:latest" }, { "name": "deploy-deployment", "type": "apply", "component": "outerloop-deploy", "componentType": "kubernetes" }, { "name": "deploy-another-deployment", "type": "apply", "component": "another-deployment", "componentType": "kubernetes" }, { "name": "outerloop-pod-command", "type": "apply", "component": "outerloop-pod", "componentType": "kubernetes" }, { "name": "deploy", "type": "composite", "group": "deploy", "isDefault": true } ]