Update devfile/library to support pod-overrides and container-overrides attributes and add integration test for it #6512

valaparthvi · 2023-01-18T17:48:09Z

What type of PR is this:
/kind feature

What does this PR do / why we need it:
This PR updates the devfile/library to devfile/library@0d04f79 to support pod-overrides and container-overrides. It also adds integration test for the same.

Which issue(s) this PR fixes:

Fixes #5977

PR acceptance criteria:

Unit test
Integration test
Documentation

How to test changes / Special notes to the reviewer:
Steps to update the library:

Devfile Update: go get github.com/devfile/library/v2@0d04f79
Replace all the imports of github.com/devfile/library to github.com/devfile/library/v2
go mod vendor && go mod tidy

netlify · 2023-01-18T17:48:14Z

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name	Link
🔨 Latest commit	`373572d`
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63ce7bbe297ac70008bf1bbc

odo-robot · 2023-01-18T17:54:27Z

OpenShift Tests on commit 0c8a913 finished successfully.
View logs: TXT HTML

odo-robot · 2023-01-18T18:07:31Z

Windows Tests (OCP) on commit 0c8a913 finished with errors.
View logs: TXT HTML

odo-robot · 2023-01-18T18:09:05Z

Kubernetes Tests on commit 0c8a913 finished successfully.
View logs: TXT HTML

odo-robot · 2023-01-18T20:10:19Z

NoCluster Tests on commit 0c8a913 finished successfully.
View logs: TXT HTML

odo-robot · 2023-01-18T20:14:56Z

Unit Tests on commit 0c8a913 finished successfully.
View logs: TXT HTML

odo-robot · 2023-01-18T21:01:15Z

Validate Tests on commit 0c8a913 finished successfully.
View logs: TXT HTML

valaparthvi · 2023-01-19T12:04:07Z

/retest-required

feloy · 2023-01-19T16:09:51Z

tests/integration/cmd_dev_test.go

+		)
+		BeforeEach(func() {
+			helper.CopyExample(filepath.Join("source", "nodejs"), commonVar.Context)
+			helper.CopyExampleDevFile(filepath.Join("source", "devfiles", "nodejs", "devfile-pod-container-overrides.yaml"), filepath.Join(commonVar.Context, "devfile.yaml"))


Please use random name, as in #6504

rm3l · 2023-01-20T09:32:32Z

tests/integration/cmd_dev_test.go

+			helper.CopyExample(filepath.Join("source", "nodejs"), commonVar.Context)
+			helper.CopyExampleDevFile(filepath.Join("source", "devfiles", "nodejs", "devfile-pod-container-overrides.yaml"), filepath.Join(commonVar.Context, "devfile.yaml"), helper.DevfileMetadataNameSetter(cmpName))
+		})
+		It("should override the content in the pod it creates for the component on the cluster", func() {


Just curious: can we use the same test on Podman as well? Or if it does not work, maybe we can try to override some specific fields recognized by Podman..

feloy · 2023-01-20T15:41:14Z

You get this error in podman tests with Podman v3 (in CI):

error starting container 78000590aeaab78ab0d0ed6f00de89bef493feb5900ba9d9f810c893f5822a6c: the requested cgroup controller `cpu` is not available: OCI runtime error

valaparthvi · 2023-01-20T16:23:57Z

You get this error in podman tests with Podman v3 (in CI):

error starting container 78000590aeaab78ab0d0ed6f00de89bef493feb5900ba9d9f810c893f5822a6c: the requested cgroup controller `cpu` is not available: OCI runtime error

It passed on my local podman so I figured it would work here too.

feloy · 2023-01-20T16:29:21Z

You get this error in podman tests with Podman v3 (in CI):
error starting container 78000590aeaab78ab0d0ed6f00de89bef493feb5900ba9d9f810c893f5822a6c: the requested cgroup controller `cpu` is not available: OCI runtime error
It passed on my local podman so I figured it would work here too.

It is probably a restriction on the CI VM

valaparthvi · 2023-01-20T16:43:08Z

You get this error in podman tests with Podman v3 (in CI):
error starting container 78000590aeaab78ab0d0ed6f00de89bef493feb5900ba9d9f810c893f5822a6c: the requested cgroup controller `cpu` is not available: OCI runtime error
It passed on my local podman so I figured it would work here too.
It is probably a restriction on the CI VM

I found this(https://github.com/containers/podman/blob/main/troubleshooting.md#26-running-containers-with-resource-limits-fails-with-a-permissions-error) on Podman FAQ, do you think we can set resource limit if that will not affect other tests?

feloy · 2023-01-23T08:51:49Z

You get this error in podman tests with Podman v3 (in CI):
error starting container 78000590aeaab78ab0d0ed6f00de89bef493feb5900ba9d9f810c893f5822a6c: the requested cgroup controller `cpu` is not available: OCI runtime error
It passed on my local podman so I figured it would work here too.
It is probably a restriction on the CI VM
I found this(https://github.com/containers/podman/blob/main/troubleshooting.md#26-running-containers-with-resource-limits-fails-with-a-permissions-error) on Podman FAQ, do you think we can set resource limit if that will not affect other tests?

I would modify another field for this test, as resources setting is too much error prone, and we don't specifically want to test modification of resources fields.

PS: I find this tweet very apropos ;) https://twitter.com/manekinekko/status/1617208921957040131?s=20&t=R8ofTwvwU_ypQTIjrlIBZQ

Signed-off-by: Parthvi Vala <[email protected]> Attempt at fixing CI failures Signed-off-by: Parthvi Vala <[email protected]>

Signed-off-by: Parthvi Vala <[email protected]>

sonarqubecloud · 2023-01-23T14:57:34Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.3% Duplication

rm3l · 2023-01-23T16:17:38Z

/override windows-integration-test/Windows-test

  Expected
      <*url.Error | 0xc0008a68d0>: {
          Op: "Post",
          URL: "http://127.0.0.1:60053/api/newuser",
          Err: <*errors.errorString | 0xc00007c130>{s: "EOF"},
      }
  to be nil
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3089/tests/e2escenarios/e2e_test.go:293

  There were additional failures detected after the initial failure.  Here's a summary - for full details run Ginkgo in verbose mode:
    [FAILED] in [AfterEach] at C:/Users/Administrator.ANSIBLE-TEST-VS/3089/tests/helper/helper_filesystem.go:49
------------------------------


Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  C:/Users/Administrator.ANSIBLE-TEST-VS/3089/tests/e2escenarios/e2e_test.go:293

Ran 7 of 7 Specs in 207.555 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test.

openshift-ci · 2023-01-23T16:17:43Z

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

Details

In response to this:

/override windows-integration-test/Windows-test

 Expected
     <*url.Error | 0xc0008a68d0>: {
         Op: "Post",
         URL: "http://127.0.0.1:60053/api/newuser",
         Err: <*errors.errorString | 0xc00007c130>{s: "EOF"},
     }
 to be nil
 In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3089/tests/e2escenarios/e2e_test.go:293

 There were additional failures detected after the initial failure.  Here's a summary - for full details run Ginkgo in verbose mode:
   [FAILED] in [AfterEach] at C:/Users/Administrator.ANSIBLE-TEST-VS/3089/tests/helper/helper_filesystem.go:49
------------------------------


Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 C:/Users/Administrator.ANSIBLE-TEST-VS/3089/tests/e2escenarios/e2e_test.go:293

Ran 7 of 7 Specs in 207.555 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

feloy · 2023-01-23T17:21:56Z

/override ci/prow/v4.11-integration-e2e

openshift-ci · 2023-01-23T17:22:03Z

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

Details

In response to this:

/override ci/prow/v4.11-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jan 18, 2023

openshift-ci bot requested review from feloy and kadel January 18, 2023 17:48

valaparthvi requested a review from rm3l January 18, 2023 17:49

valaparthvi closed this Jan 19, 2023

valaparthvi reopened this Jan 19, 2023

feloy suggested changes Jan 19, 2023

View reviewed changes

openshift-ci bot assigned feloy Jan 19, 2023

valaparthvi force-pushed the 5977_update_devfile_library branch 2 times, most recently from 0d80fd8 to 5d988b1 Compare January 20, 2023 08:36

rm3l reviewed Jan 20, 2023

View reviewed changes

valaparthvi requested review from feloy and rm3l January 20, 2023 14:31

valaparthvi closed this Jan 23, 2023

valaparthvi reopened this Jan 23, 2023

valaparthvi added 2 commits January 23, 2023 17:50

Update the Devfile library

2826409

Add test for container-overrides and pod-overrides attributes

83c4ebd

Signed-off-by: Parthvi Vala <[email protected]> Attempt at fixing CI failures Signed-off-by: Parthvi Vala <[email protected]>

valaparthvi added 8 commits January 23, 2023 17:50

Fix CI failure

1bb1475

Attempt at fixing OC integration test failures

0907852

Signed-off-by: Parthvi Vala <[email protected]>

Use random name in integration test

40486d3

Signed-off-by: Parthvi Vala <[email protected]>

Rebase and fix integration test failure

d07a2d2

Signed-off-by: Parthvi Vala <[email protected]>

Make integration test work for podman

5502c90

Signed-off-by: Parthvi Vala <[email protected]>

Temp attempt at fixing podman test for GH

af19e9c

Signed-off-by: Parthvi Vala <[email protected]>

Another attempt at fixing CI test for podman

80fcec9

Signed-off-by: Parthvi Vala <[email protected]>

One more attempt at fixing integration test for podman

373572d

Signed-off-by: Parthvi Vala <[email protected]>

valaparthvi force-pushed the 5977_update_devfile_library branch from 5ce3198 to 373572d Compare January 23, 2023 12:21

feloy approved these changes Jan 23, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 23, 2023

valaparthvi closed this Jan 23, 2023

valaparthvi reopened this Jan 23, 2023

openshift-merge-robot merged commit 19f8e0e into redhat-developer:main Jan 23, 2023

vinny-sabatini mentioned this pull request Jan 23, 2023

WIP set service account for dev container via component attributes #6111

Closed

3 tasks

rm3l mentioned this pull request Jan 30, 2023

blog: odo with .NET and PostgreSQL on OpenShift #6500

Merged

Update devfile/library to support pod-overrides and container-overrides attributes and add integration test for it #6512

Update devfile/library to support pod-overrides and container-overrides attributes and add integration test for it #6512

Uh oh!

Conversation

valaparthvi commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for odo-docusaurus-preview canceled.

Uh oh!

odo-robot bot commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

valaparthvi commented Jan 19, 2023

Uh oh!

feloy Jan 19, 2023

Choose a reason for hiding this comment

Uh oh!

rm3l Jan 20, 2023

Choose a reason for hiding this comment

Uh oh!

feloy commented Jan 20, 2023

Uh oh!

valaparthvi commented Jan 20, 2023

Uh oh!

feloy commented Jan 20, 2023

Uh oh!

valaparthvi commented Jan 20, 2023

Uh oh!

feloy commented Jan 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Jan 23, 2023

Uh oh!

rm3l commented Jan 23, 2023

Uh oh!

openshift-ci bot commented Jan 23, 2023

Uh oh!

feloy commented Jan 23, 2023

Uh oh!

openshift-ci bot commented Jan 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

valaparthvi commented Jan 18, 2023 •

edited

Loading

netlify bot commented Jan 18, 2023 •

edited

Loading

odo-robot bot commented Jan 18, 2023 •

edited

Loading

odo-robot bot commented Jan 18, 2023 •

edited

Loading

odo-robot bot commented Jan 18, 2023 •

edited

Loading

odo-robot bot commented Jan 18, 2023 •

edited

Loading

odo-robot bot commented Jan 18, 2023 •

edited

Loading

odo-robot bot commented Jan 18, 2023 •

edited

Loading

feloy commented Jan 23, 2023 •

edited

Loading