Feature/RZA-250097: Refactor the Blog Page UI and Added Stories Section #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
recursivezero
requested changes
Jul 5, 2025
Owner
recursivezero
left a comment
recursivezero
left a comment
There was a problem hiding this comment.
- remove inline css
- extract svg into icons file
- fix font size and alignment for large and mobile screen
| <BackArrow/> | ||
| <div class="container__blog"> | ||
| <header class="mb-12 text-center"> | ||
| <h1 |
Owner
There was a problem hiding this comment.
remove inline style from all and use in blog.css or separate blog-article.css file using class names and no duplicate/unused css
src/pages/blog/[slug].astro
Outdated
| <header class="blog-post-header"> | ||
| <h1 | ||
| style="background: linear-gradient(90deg, var(--text), var(--primary-light)); -webkit-background-clip: text; -webkit-text-fill-color: transparent;" | ||
| style="font-size:45px; background: linear-gradient(90deg, var(--text), var(--primary-light)); -webkit-background-clip: text; -webkit-text-fill-color: transparent;" |
Owner
There was a problem hiding this comment.
remove inline style , use something written on blog,css
src/pages/blog/[slug].astro
Outdated
| { | ||
| validatedData.description && ( | ||
| <p class="mx-auto mt-4 max-w-2xl text-lg" style="color: var(--secondary)"> | ||
| <p class="mx-auto mt-4 max-w-2xl text-lg" style="font-size:20px; color: var(--secondary)"> |
Owner
There was a problem hiding this comment.
this mt-4 max-w? these tailwind willnot work here as we are not having tailwind
Collaborator
Author
|
1046prt
changed the title
Collaborator
Author
|
…nhance layout for better readability
…tency and readability
1046prt
force-pushed
the
feature/RZA-250097
branch
from
f0e7382 to
d301887
Compare
Owner
|
https://web.dev/patterns/components/settings?hl=en#css try this kind of slider |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
/public/images/blogdirectory.Fixes #97
Here are some screenshots: