Skip to content

Conversation

@Suresh-Chelani
Copy link
Collaborator

@Suresh-Chelani Suresh-Chelani commented Jul 2, 2025

Pull Request Template

Description

This PR enhances the popup functionality by migrating from a traditional HTML/CSS/JavaScript-based implementation to the native Popover API.

Problem:

The application already had existing Popover API usage in both the sidebar and crossword components. When I attempted to implement the Popover API for the popup, it caused conflicts—particularly due to overlapping behavior with the sidebar.

Solution:

To resolve this, I referred to the crossword component's popover implementation, rewrote the popup logic accordingly, and separated its logic cleanly from the sidebar. I also fixed minor bugs and enhanced responsiveness and styling for a more consistent user experience across devices.

Fixes: optimized popup rendering and popover conflict issue

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The changes were tested manually across different devices and screen sizes. Verified that the popup opens and closes correctly, does not interfere with the sidebar, and responds appropriately to user actions.

  • Manual functional testing
  • Responsive testing on mobile and desktop

Test Configuration:

  • Browser: Chrome, Edge
  • Device: Windows Desktop, Android
  • Toolchain: Astro + Native Popover API + CSS

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@Suresh-Chelani
Copy link
Collaborator Author

image
image

@xkeshav xkeshav changed the title Bugfix/rzb 250106 Bugfix/rzb-250106: Map popup issue fixed with popoverAPI Jul 3, 2025
@xkeshav xkeshav merged commit 173299e into develop Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants