Fix version on refmt #2701
Merged
Fix version on refmt #2701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
anmonteiro
reviewed
Mar 24, 2023
esy.json
Outdated
| "version": "3.8.1", | ||
| "version": "3.8.2", | ||
| "dependencies": { | ||
| "@opam/dune": "3.6.2", |
Member
There was a problem hiding this comment.
we should probably be on the same dune version as dune-build-info
anmonteiro
reviewed
Mar 24, 2023
reason.json
Outdated
| "@opam/result": "*", | ||
| "@opam/ppx_derivers": "< 2.0.0", | ||
| "@opam/dune": "2.9.3" | ||
| "@opam/dune": "2.9.3", |
Member
There was a problem hiding this comment.
let's try to use the same dune version across all .json files.
Member
Author
There was a problem hiding this comment.
Updated in 22e86a6 + update reason.json/rtop.json
davesnx
force-pushed
the
Fix-version-on-refmt
branch
from
46841b1 to
2447429
Compare
SanderSpies
added a commit
to SanderSpies/reason
that referenced
this pull request
Apr 18, 2023
* master: (38 commits) chore: remove old BS_NO_COMPILER_PATCH flag (reasonml#2710) Improve printing of modules types with one line inside (reasonml#2709) generate opam files with dune (reasonml#2704) Fix version on refmt (reasonml#2701) Drop the result dependency (reasonml#2703) Remove old CI and test.sh (reasonml#2705) Migrate tests to cram suite (reasonml#2694) Make sure win doesnt break when importing (reasonml#2700) Fix top level extensions (reasonml#2693) Install before importing deps Update package json and install esy normally Re-arrange esy install Reduce install esy time Use master branch instead of main Ignore _export from esy Rename refmt_test to test Add esy-ci and opam-ci Remove jbuild-ignore chore: update nix flake (reasonml#2692) chore(readme): clarify 3.9 is unreleased ...
SanderSpies
added a commit
to SanderSpies/reason
that referenced
this pull request
Apr 18, 2023
* master: (38 commits) chore: remove old BS_NO_COMPILER_PATCH flag (reasonml#2710) Improve printing of modules types with one line inside (reasonml#2709) generate opam files with dune (reasonml#2704) Fix version on refmt (reasonml#2701) Drop the result dependency (reasonml#2703) Remove old CI and test.sh (reasonml#2705) Migrate tests to cram suite (reasonml#2694) Make sure win doesnt break when importing (reasonml#2700) Fix top level extensions (reasonml#2693) Install before importing deps Update package json and install esy normally Re-arrange esy install Reduce install esy time Use master branch instead of main Ignore _export from esy Rename refmt_test to test Add esy-ci and opam-ci Remove jbuild-ignore chore: update nix flake (reasonml#2692) chore(readme): clarify 3.9 is unreleased ...
SanderSpies
added a commit
to SanderSpies/reason
that referenced
this pull request
May 4, 2023
* master: fix: binary parser (reasonml#2713) Improve functor printing. (reasonml#2683) chore: remove old BS_NO_COMPILER_PATCH flag (reasonml#2710) Improve printing of modules types with one line inside (reasonml#2709) generate opam files with dune (reasonml#2704) Fix version on refmt (reasonml#2701) Drop the result dependency (reasonml#2703) Remove old CI and test.sh (reasonml#2705) Migrate tests to cram suite (reasonml#2694) Make sure win doesnt break when importing (reasonml#2700) Fix top level extensions (reasonml#2693) Install before importing deps Update package json and install esy normally Re-arrange esy install Reduce install esy time Use master branch instead of main Ignore _export from esy Rename refmt_test to test Add esy-ci and opam-ci Remove jbuild-ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a step close to solve the issue with the release process being broken.
Fixing the version on running
refmt --versionThis would always print the version from
dune-projectwhich would need to be in sync withreason.json,package.json,esy.jsonwhich is not ideal.git_commit.mlIn the future the publish is going to be automated by CI, only updating the version on the
dune-projectfile will propagate to all releases.