Prototype #13
Merged
Prototype #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTML and XHTML test pages to validate UA Stylesheets against HTML5 Suggested Rendering (https://www.w3.org/TR/html5/rendering.html)
This reverts commit 7cef69d.
llemeurfr
reviewed
Aug 28, 2017
Contributor
llemeurfr
left a comment
llemeurfr
left a comment
There was a problem hiding this comment.
Minor requests for modifications before merging.
README.md
Outdated
|
|
||
| ## Scope of this project | ||
|
|
||
| The major goal of Readium CSS is to provide implementers with reliable and modern styles for EPUB 2 and EPUB 3 publications, and authors with good interoperability. |
Contributor
There was a problem hiding this comment.
isn't it "... provide implementers and authors with... publications, with good interoperability." ?
README.md
Outdated
|
|
||
| The major goal of Readium CSS is to provide implementers with reliable and modern styles for EPUB 2 and EPUB 3 publications, and authors with good interoperability. | ||
|
|
||
| Those stylesheets were not designed and should not be used for (Portable) Web Publications, or other existing formats like FB2, PRC, Mobi, TEI, etc. |
Contributor
There was a problem hiding this comment.
We should be clearer that WP and PWP are WIP.
|
|
||
| ## Testing | ||
|
|
||
| You can use the [webpub manifest prototype](https://github.com/HadrienGardeur/webpub-manifest/tree/gh-pages/examples/paged-viewer) with the [RS-streamer-js](https://github.com/edrlab/r2-streamer-js) in a local development environment. |
Contributor
There was a problem hiding this comment.
This needs clarification. We'll ask Daniel to provide them after the merge.
README.md
Outdated
|
|
||
| There is no public implementation of Readium CSS so far. | ||
|
|
||
| Consequently, if you are encountering rendering issues with Readium, please report them on the [Readium-shared-js repository](https://github.com/readium/readium-shared-js). |
Contributor
There was a problem hiding this comment.
better ... on the github section dedicated to the proper Readium project (e.g Readium-shared-js ...).
Because they are several Readium projects (Readium SDK, Readium Cloud Reader, Readium Chrom app) some of them split in different github sections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype version of Readium CSS. It provides implementers with:
Docs are WIP, although an EPUB file is available as a snapshot for the prototype.
Completed the ReadMe and added contributing guidelines.
@llemeurfr Does this looks good to you?