Skip to content

Finished translation of hydrate page #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alinkedd merged 2 commits into from
Dec 24, 2023
Merged

Finished translation of hydrate page #503

alinkedd merged 2 commits into from
Dec 24, 2023

Conversation

@heshvab
Copy link
Contributor

@heshvab heshvab commented Nov 30, 2023

No description provided.

alinkedd
alinkedd reviewed Dec 5, 2023
View reviewed changes
@heshvab heshvab marked this pull request as draft December 6, 2023 22:56
@bkatsevych bkatsevych mentioned this pull request Dec 8, 2023
Open
@heshvab heshvab marked this pull request as ready for review December 8, 2023 15:21
@heshvab
Copy link
Contributor Author

heshvab commented Dec 8, 2023

Додав дефіс до прикладок (DOM-вузол, HTML-вміст)
Змінив "на клієнті/сервері" на "на стороні клієнта/сервера"
Змінив "контент" на "вміст"
Hello, world! залишив на англійській мові
Замінив "приглушення" (suppressing) на "приховування"
Та інші виправлення

@alinkedd
Copy link
Collaborator

alinkedd commented Dec 8, 2023

@bkatsevych глянь pr, як буде час

@alinkedd alinkedd requested a review from bkatsevych December 10, 2023 19:58
bkatsevych
bkatsevych requested changes Dec 10, 2023
View reviewed changes
Copy link
Collaborator

@bkatsevych bkatsevych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alinkedd
Перегляньте теж

@alinkedd
Copy link
Collaborator

alinkedd commented Dec 11, 2023

@GeorgeShvab я думаю, оці пару коментарів зверху і на "опційний" замінити, і буде чудово
ну і було б круто ребейзнути це на свіжий майстер і зісквошити коміти в один, бо не хочеться десятки комітів мержити

@heshvab heshvab marked this pull request as draft December 17, 2023 14:46
@heshvab heshvab force-pushed the uk-translation-hydrate branch from a1a4135 to 32c2f0f Compare December 17, 2023 16:48
@heshvab heshvab marked this pull request as ready for review December 17, 2023 16:49
@heshvab
Copy link
Contributor Author

heshvab commented Dec 17, 2023

Замінив "необов'язковий" на "опційний"
Додав інші запропоновані виправлення
Зісквошив коміти в один

@heshvab heshvab requested a review from bkatsevych December 21, 2023 20:59
alinkedd
alinkedd reviewed Dec 23, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 24, 2023

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@alinkedd alinkedd merged commit 3233c06 into reactjs:main Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alinkedd alinkedd alinkedd approved these changes

@bkatsevych bkatsevych bkatsevych approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heshvab @alinkedd @bkatsevych