[Documentation] Details/Example for Indexes as keys#111
[Documentation] Details/Example for Indexes as keys#111bvaughn merged 6 commits intoreactjs:masterfrom ajcumine:docs-no-keys-in-lists
Conversation
|
Deploy preview ready! Built with commit 383a7cb |
content/docs/lists-and-keys.md
Outdated
There was a problem hiding this comment.
The /react prefix should not be added to this link.
content/docs/reconciliation.md
Outdated
There was a problem hiding this comment.
I actually preferred the original wording for this paragraph.
content/docs/reconciliation.md
Outdated
There was a problem hiding this comment.
cc @gaearon to import these changes into his CodePen profile.
|
Thanks for the swift review @bvaughn, I've made the suggested change and fixed the link I had wrong. |
|
I think these changes look reasonable. I prefer not to merge until we update the Codepen links to point at our standard account (codepen.io/gaearon) so I'll hand this issue to @gaearon for now. 😄 |
|
Hi @ajcumine. Sorry for dropping the ball on this PR. I couldn't merge it until we had an answer for the Codepen issue I mentioned previously. Now we do. As of PR #245, we're now able to directly link to code examples stored right here in this project's git repository. If you'd be willing to update this PR to move the forked examples that you made on Codepen within this project (in the |
|
Hi @bvaughn. No worries, I'll update it in the next few days and get everything updated for you to review. |
|
@bvaughn I found some time to get this done today :) It's all ready for your review, thanks again |
This aims to add more information to the documentation and address #79