Added codemod for unstable_handleError -> componentDidCatch#158
Merged
bvaughn merged 2 commits intoreactjs:masterfrom Jul 17, 2017
Merged
Added codemod for unstable_handleError -> componentDidCatch#158bvaughn merged 2 commits intoreactjs:masterfrom
bvaughn merged 2 commits intoreactjs:masterfrom
Conversation
Contributor
Author
|
cc @flarnie for review 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React introduced the experimental "error boundaries" feature in version 15. Components define an
unstable_handleErrormethod to opt into this feature. Version 16 finalizes support for error boundaries, but with a new name-componentDidCatch.This codemod is pretty simplistic. It renames all identifiers named
unstable_handleError. At first (a8be6bb) I thought about restricting renamed identifiers to class properties/methods and object expressions. But that felt fragile. (What if a react component directly called its ownunstable_handleErrormethod? We'd want to rename the call too.) So I broadened it (411750c). The broader approach runs the possibility of false positives but I think the name is sufficiently unique that it's okay.Relates to the "make error boundaries official" beta-blocker in facebook/react/issues/8854