This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Include HorizontalBar as an available type#122
Merged
austinpray merged 3 commits intoreactjs:chartjs-v2from Apr 6, 2017
Merged
Include HorizontalBar as an available type#122austinpray merged 3 commits intoreactjs:chartjs-v2from
austinpray merged 3 commits intoreactjs:chartjs-v2from
Conversation
KeKs0r
reviewed
Oct 26, 2016
| classData.initializeChart = function(nextProps) { | ||
| var el = ReactDOM.findDOMNode(this); | ||
| var ctx = el.getContext("2d"); | ||
| var type = (chartType === 'PolarArea') ? 'polarArea':chartType.toLowerCase(); |
There was a problem hiding this comment.
We could also write it dynamically in order to allow future types as well:
var type = chartType.charAt(0).toLowerCase() + chartType.slice(1);|
Can we merge this, please? |
|
Thanks for taking care of this @austinpray ! When can we expect a new release on npm with this fix? |
Member
|
published as |
|
Thanks for publishing it. |
|
@achanda you can install the specific version with To do so, I had to add the export to module.exports = {
Bar: require('./lib/bar'),
HorizontalBar: require('./lib/horizontal-bar'),
...Edit: Just opened a pull request #179 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
horizontalBaras an available type of chart.There is a small refactor to the way the
typepassed into chart.js to account for more that can be covered by a simple ternary assignment.