Skip to content

[DONE] Translating testing overview #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fcmam5 merged 6 commits into from
Nov 2, 2019
Merged

[DONE] Translating testing overview #195

Fcmam5 merged 6 commits into from
Nov 2, 2019

Conversation

@mohdule
Copy link
Contributor

@mohdule mohdule commented Oct 27, 2019

No description provided.

@netlify
Copy link

netlify bot commented Oct 27, 2019 •
edited
Loading

Deploy preview for ar-reactjs ready!

Built with commit 8d87dc2

https://deploy-preview-195--ar-reactjs.netlify.com

@Fcmam5 Fcmam5 self-assigned this Oct 27, 2019
@tesseralis tesseralis mentioned this pull request Oct 28, 2019
Closed
@mohdule mohdule changed the title [WIP] Translating testing overview [DONE] Translating testing overview Oct 28, 2019
@mohdule
Copy link
Contributor Author

mohdule commented Oct 31, 2019

I'm done 🙂

Fcmam5
Fcmam5 requested changes Oct 31, 2019
View reviewed changes
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things to correct if you don't mind 😄, it's just about همزات and a comma فاصلة.
Also, please next time make sure to commit only the files that are related to your PR, like for this one other pages had changes, I guess that it's because of your linter/editor.

@mohdule
Copy link
Contributor Author

mohdule commented Oct 31, 2019

Sure thing, no worries 🙂
should i remove all the همزات though ?

as for the linting issue, that's actually not my linter, i just ran yarn check-all as instructed on the repo's contribution guide.

3imed-jaberi
3imed-jaberi requested changes Oct 31, 2019
View reviewed changes
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to correct all comma الفاصلة and you should also push only the file you selected ( PR ) ..

@3imed-jaberi 3imed-jaberi requested a review from Fcmam5 October 31, 2019 18:50
@3imed-jaberi 3imed-jaberi self-assigned this Oct 31, 2019
@3imed-jaberi 3imed-jaberi requested review from Fcmam5 and removed request for Fcmam5 October 31, 2019 23:55
Fcmam5
Fcmam5 approved these changes Nov 2, 2019
View reviewed changes
Copy link
Collaborator

@Fcmam5 Fcmam5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations Mohannad for your first contribution in ar.reactjs.org 👏 !

@Fcmam5 Fcmam5 merged commit 0cb0b36 into reactjs:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fcmam5 Fcmam5 Fcmam5 approved these changes

@Aissaoui-Ahmed Aissaoui-Ahmed Aissaoui-Ahmed approved these changes

@3imed-jaberi 3imed-jaberi 3imed-jaberi approved these changes

Assignees

@Fcmam5 Fcmam5

@3imed-jaberi 3imed-jaberi

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mohdule @Fcmam5 @Aissaoui-Ahmed @3imed-jaberi