-
Notifications
You must be signed in to change notification settings - Fork 113
Done translating high-order components #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview for ar-reactjs ready! Built with commit 68c30e6 |
|
Done :) |
|
Hi @mohshbool, please review this page. Thanks. |
Great work on your translation. I just had one comment because I think this is a big change. |
We have faced the same problem in
|
|
Should we stick with the glossary or with hsoub translation? |
not sure but I personally went with the glossary, I actually only compared my translation with hsoub's after I was done translating, rather than basing my translation on it |
I suggested that we stick to a wiki-hasoub at the beginning and when we finish everything ( first release ) we organize a good glossary and fix all small bugs.@iRayan7 @Fcmam5 @aladin002dz @mohshbool @maskeddeveloper |
This is the approach I am supporting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please allow me to make those little suggestions 😃
i will continue the review process another time
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
@mohshbool all your suggestions committed! ;) |
that's great! I have not finished reviewing, I'm sorry but I've been a bit busy, I will finish the review by midnight (utc+3) hopefully! |
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
Co-Authored-By: Mohammad Shbool <[email protected]>
booking the page "Higher-order components" translation