Skip to content

Conversation

@aladin002dz
Copy link
Member

booking the page "Higher-order components" translation

@netlify
Copy link

netlify bot commented Jun 28, 2019

Deploy preview for ar-reactjs ready!

Built with commit 68c30e6

https://deploy-preview-119--ar-reactjs.netlify.com

@aladin002dz aladin002dz changed the title start translating high-order components Done translating high-order components Jun 29, 2019
@aladin002dz
Copy link
Member Author

Done :)

@iRayan7
Copy link
Member

iRayan7 commented Jun 29, 2019

Hi @mohshbool, please review this page. Thanks.

@mohshbool
Copy link
Member

Done :)

Great work on your translation. I just had one comment because I think this is a big change.
I noticed that you translated 'high-order components' => 'المكونات ذات الترتيب الأعلى' but according to the glossary it should be 'مكونات من المرتبة الأعلى'.

@3imed-jaberi
Copy link
Member

Done :)

Great work on your translation. I just had one comment because I think this is a big change.
I noticed that you translated 'high-order components' => 'المكونات ذات الترتيب الأعلى' but according to the glossary it should be 'مكونات من المرتبة الأعلى'.

We have faced the same problem in docs/nav.yml ( me & @Fcmam5 ) .. i think المكونات ذات الترتيب الأعلى is better ..

--> should we update the glossary in this point.

@aladin002dz
Copy link
Member Author

Should we stick with the glossary or with hsoub translation?

@mohshbool
Copy link
Member

Should we stick with the glossary or with hsoub translation?

not sure but I personally went with the glossary, I actually only compared my translation with hsoub's after I was done translating, rather than basing my translation on it

@3imed-jaberi
Copy link
Member

3imed-jaberi commented Jun 29, 2019

Should we stick with the glossary or with hsoub translation?

I suggested that we stick to a wiki-hasoub at the beginning and when we finish everything ( first release ) we organize a good glossary and fix all small bugs.

@iRayan7 @Fcmam5 @aladin002dz @mohshbool @maskeddeveloper

@aladin002dz
Copy link
Member Author

Should we stick with the glossary or with hsoub translation?

I suggested that we stick to a wiki-hasoub at the beginning and when we finish everything ( first release ) we organize a good glossary and fix all small bugs.

@iRayan7 @Fcmam5 @aladin002dz @mohshbool @maskeddeveloper

This is the approach I am supporting.

Copy link
Member

@mohshbool mohshbool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please allow me to make those little suggestions 😃
i will continue the review process another time

@aladin002dz
Copy link
Member Author

please allow me to make those little suggestions 😃
i will continue the review process another time

@mohshbool all your suggestions committed! ;)

@mohshbool
Copy link
Member

please allow me to make those little suggestions 😃
i will continue the review process another time

@mohshbool all your suggestions committed! ;)

that's great! I have not finished reviewing, I'm sorry but I've been a bit busy, I will finish the review by midnight (utc+3) hopefully!

@mohshbool mohshbool merged commit a2a6676 into reactjs:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants