feat: generate code for derived non refit methods.#1875
Merged
ChrisPulman merged 1 commit intoreactiveui:mainfrom Oct 22, 2024
Merged
feat: generate code for derived non refit methods.#1875ChrisPulman merged 1 commit intoreactiveui:mainfrom
ChrisPulman merged 1 commit intoreactiveui:mainfrom
Conversation
512eac3 to
07d1563
Compare
Contributor
Author
|
Thanks again. Do you have any issues you'd like me to look at before the release ie #1878?
|
07d1563 to
816bfbd
Compare
816bfbd to
f2bd209
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1875 +/- ##
==========================================
- Coverage 87.73% 84.28% -3.45%
==========================================
Files 33 36 +3
Lines 2348 2476 +128
Branches 294 347 +53
==========================================
+ Hits 2060 2087 +27
- Misses 208 310 +102
+ Partials 80 79 -1 ☔ View full report in Codecov by Sentry. |
ChrisPulman
approved these changes
Oct 20, 2024
63f9157 to
213ef14
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1801
@ChrisPulman do you have any guidance here? Is this PR blocking you from the next release.