feat: update InterfaceStubGenerator to be an incremental generator#1864
feat: update InterfaceStubGenerator to be an incremental generator#1864ChrisPulman merged 1 commit intoreactiveui:mainfrom
InterfaceStubGenerator to be an incremental generator#1864Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1864 +/- ##
==========================================
- Coverage 87.73% 83.80% -3.93%
==========================================
Files 33 36 +3
Lines 2348 2476 +128
Branches 294 347 +53
==========================================
+ Hits 2060 2075 +15
- Misses 208 318 +110
- Partials 80 83 +3 ☔ View full report in Codecov by Sentry. |
a7a744e to
374e0e1
Compare
|
Hi @TimothyMakkison , do you think you could try to update dependency verify.sourcegenerators to 2.5.0 along with this PR or as a separate PR. |
Sure, I don't think changing this should affect me.
nw, it looks like most of the changes can be copied over or ignored, shouldn't be a problem.
Thanks 😄, in theory this should be a fully backwards compatible change and will only provide a smoother ide experience for users. Assuming that I haven't broken anything🤞. I'm not too familiar with versioning so I'm happy to leave the decision to you. Does refit have a pre release version? I was hoping to finish this in a couple of days, I need to do some cleanup, re-read |
a56e5d3 to
4729184
Compare
eab1de1 to
d532015
Compare
|
Should be sound 🤞 . I tried to keep the logic the same and do a straight translation from the original, however there are differences. Note that bools passed to I'll probably look into #1801 or #1389 next. I could probably do #1801 over the weekend if you want it in the next update. |
d532015 to
59910d7
Compare
|
Shall we get 1801 out the way first as it's producing errors in the code, then tackle 1389 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Closes #1791
Parserconverts eachINamedTypeSymbolintoInterfaceModeland extracts additional information.Modeltypes should be structurally equatable to enable incremental generation.ImmutableEquatableArrayis a structurally equatable collection.Emittertakes each model and creates an interface stub.TODO
Future changes
ToListcallsImmutableEquatableArraycould be made into a struct.System.Text.Jsonand rename files toInterfaceStubGenerator.ParseretcBenchmarks
Original
Incremental