feat: add non refit method raises diagnostic test#1860
Merged
ChrisPulman merged 2 commits intoreactiveui:mainfrom Oct 5, 2024
Merged
feat: add non refit method raises diagnostic test#1860ChrisPulman merged 2 commits intoreactiveui:mainfrom
ChrisPulman merged 2 commits intoreactiveui:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1860 +/- ##
==========================================
- Coverage 87.73% 83.79% -3.94%
==========================================
Files 33 36 +3
Lines 2348 2456 +108
Branches 294 346 +52
==========================================
- Hits 2060 2058 -2
- Misses 208 316 +108
- Partials 80 82 +2 ☔ View full report in Codecov by Sentry. |
TimothyMakkison
force-pushed
the
non_refit_diagnostic_test
branch
from
4df55df to
066b5e5
Compare
ChrisPulman
approved these changes
Oct 5, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test to ensure that non refit methods generate
NotImplementedExceptionand raise a diagnostic