Fix to disable RXUISG0016 analyzer for read-only properties#70
Merged
ChrisPulman merged 2 commits intomainfrom Sep 30, 2024
Merged
Fix to disable RXUISG0016 analyzer for read-only properties#70ChrisPulman merged 2 commits intomainfrom
ChrisPulman merged 2 commits intomainfrom
Conversation
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix
Closes #66
What is the current behavior?
RXUISG0016 analyzer does not have sufficient filters to ensure only public Auto properties without private or internal setters are recommended for conversion to [Reactive] properties.
What is the new behavior?
Fix to disable RXUISG0016 analyzer for read-only properties
Add filters for ReactiveProperty and ReactiveCommand to ensure they are not flagged for conversion
What might this PR break?
None, less properties will be flagged for possible conversion.
Please check if the PR fulfills these requirements
Other information: