Fix for<inheritdoc/> not respected by IntelliSense#262
Merged
ChrisPulman merged 7 commits intomainfrom Jun 18, 2025
Merged
Conversation
glennawatson
approved these changes
Jun 18, 2025
…ReactiveUI.SourceGenerators.ObservableAsPropertyAttribute.g.received.cs
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fixes #260
What is the current behavior?
#260
What is the new behavior?
This pull request introduces updates to the ReactiveUI source generators, primarily adding metadata annotations for generated code and improving code coverage exclusions. These changes enhance the maintainability and clarity of the generated code, particularly for attributes and observable properties.
Updates to attributes:
[global::System.CodeDom.Compiler.GeneratedCode]annotation to theBindableDerivedListAttributeclass to indicate the source generator version used for its creation. (src/ReactiveUI.SourceGenerator.Tests/DERIVEDLIST/BindableDerivedListGeneratorTests.FromReactiveProperties#ReactiveUI.SourceGenerators.BindableDerivedListAttribute.g.verified.cs)[global::System.CodeDom.Compiler.GeneratedCode]annotation to theObservableAsPropertyAttributeclass across multiple test files to specify the generator version and enhance traceability. (src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.*#ReactiveUI.SourceGenerators.ObservableAsPropertyAttribute.g.verified.cs)Updates to observable properties:
[global::System.CodeDom.Compiler.GeneratedCode]and[global::System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverage]annotations to observable property helpers and their initialization methods in generated classes to improve code clarity and exclude generated code from coverage metrics. (src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.*#TestNs.TestVM.ObservableAsPropertyFromObservable.g.verified.cs) [1] [2] [3] [4] [5] [6] [7][global::System.Runtime.Serialization.DataMemberAttribute]and[global::System.Text.Json.Serialization.JsonIncludeAttribute]annotations where applicable. (src/ReactiveUI.SourceGenerator.Tests/OAPH/OAPFromObservableGeneratorTests.*#TestNs.TestVM.ObservableAsPropertyFromObservable.g.verified.cs) [1] [2] [3]These changes collectively refine the generated code, making it more robust, traceable, and easier to integrate with serialization frameworks and testing tools.
What might this PR break?
None expected
Please check if the PR fulfills these requirements
Other information: