Skip to content

Fix Attribute On Partial Reactive Property Is Duplicated#251

Merged
glennawatson merged 1 commit intomainfrom
FixAttributeOnPartialPropertyIsDuplicated
Jun 10, 2025
Merged

Fix Attribute On Partial Reactive Property Is Duplicated#251
glennawatson merged 1 commit intomainfrom
FixAttributeOnPartialPropertyIsDuplicated

Conversation

@ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

Fixes #245

What is the current behavior?

#245

What is the new behavior?

This pull request introduces several changes to improve attribute handling, correct a typo in method names, and enhance the property syntax generation in the ReactiveUI.SourceGenerators project. The most important changes include refining the logic for forwarding attributes, fixing a recurring typo in the IsISchedulerType method, and updating the property syntax generation to include attribute handling.

Attribute handling improvements:

Typo correction:

What might this PR break?

None due to build failure in previous versions

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@glennawatson glennawatson merged commit 7cd82d6 into main Jun 10, 2025
1 check passed
@glennawatson glennawatson deleted the FixAttributeOnPartialPropertyIsDuplicated branch June 10, 2025 00:30
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Reactive attribute with partial property copies JsonPropertyName attribute

2 participants