Fix Forward Attributes to Generated Code#117
Merged
ChrisPulman merged 1 commit intomainfrom Nov 7, 2024
Merged
Conversation
Remove Attribute collection and forwarding
Contributor
|
Is it worth adding a couple unit tests for this one? At least some verification ones. |
glennawatson
approved these changes
Nov 7, 2024
Member
Author
We need to amend the tests to work with wpf / winforms first but definitely in the pipeline |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Attribute collection and forwarding
What kind of change does this PR introduce?
Fixes #116
What is the current behavior?
IViewFor forwards Attributes defined in source incorrectly
What is the new behavior?
IViewFor no longer forwards Attributes defined
What might this PR break?
Non due to non-compiling code if using in this way.
Please check if the PR fulfills these requirements
Other information: