chore: remove deprecated --npm flag#2504
Merged
szymonrybczak merged 1 commit intoreact-native-community:mainfrom Sep 16, 2024
Merged
chore: remove deprecated --npm flag#2504szymonrybczak merged 1 commit intoreact-native-community:mainfrom
szymonrybczak merged 1 commit intoreact-native-community:mainfrom
Conversation
thymikee
approved these changes
Sep 13, 2024
Member
|
@cortinico this is a small braking change that shouldn't affect too many users, shall we ship it as a part of 0.76 and document in the changelog? |
Collaborator
To give more context, this option was deprecated with appropriate warning for 3 major versions already. |
Member
Yup this sounds reasonable 👍 |
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
--npmflag ininitcommand has been deprecated for more than a year now in favor of using--pmflag. Sincenpmwill become a default package manager when initializing new project (#2503), I think it's a good time to remove this flag.Test Plan:
initcommand locally and use--npmflagChecklist