fix: readConfigFromDisk should ignore package.json entries#2472
Merged
szymonrybczak merged 1 commit intomainfrom Aug 23, 2024
Merged
fix: readConfigFromDisk should ignore package.json entries#2472szymonrybczak merged 1 commit intomainfrom
szymonrybczak merged 1 commit intomainfrom
Conversation
Member
|
@szymonrybczak mind looking at it? I'm not sure why we haven't used |
Member
Author
|
It was there before, but was removed with https://github.com/react-native-community/cli/pull/2343/files |
szymonrybczak
approved these changes
Aug 23, 2024
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I was trying out 0.75 and not sure why is worked before, but now the
configcommand returned this value - literally "src/index", instead of the value influenced by the config file.Test Plan:
npx react-native configreturned a valid result in the repoChecklist