feat: add version to welcome screen#2434
Merged
thymikee merged 1 commit intoreact-native-community:mainfrom Jun 27, 2024
Merged
feat: add version to welcome screen#2434thymikee merged 1 commit intoreact-native-community:mainfrom
thymikee merged 1 commit intoreact-native-community:mainfrom
Conversation
cortinico
approved these changes
Jun 25, 2024
a07d6c1 to
983cacb
Compare
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds a version to the welcome screen when the user uses a custom one.
This is helpful when testing older versions of React Native (to make sure we are initializing the correct one). It also follows the scheme that Metro does welcoming us with the version. As an extension, we could potentially fetch the latest version from npm and display it but I didn't want to add additional API call. So we display version only if user passed a custom one.
Without explicit version (latest)
With explicit version
Test Plan:
Test out init command
Checklist