fix: use preferred device in default mode#2363
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
8a0e913 to
c4017e1
Compare
Member
|
Is there a way we could fit setting and getting the preferred device from cache inside a single fn like |
|
There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
cipolleschi
approved these changes
Sep 23, 2024
cipolleschi
approved these changes
Sep 23, 2024
This was referenced Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In #2162 I added preferred device feature - it saves device id to cache, and then when running
run-ioscommand it'll push preferred device to the beginning.For some strange reason, we only enabled this for
--interactiveor--list-devicesmode. In this Pull Request preferred device is also in default mode.Test Plan:
run-ios --interactivepick a simulatorChecklist