fix: clear button should have type="button"

[afc163]

close #82

Summary by CodeRabbit

• 新功能
  • 在清除图标的按钮元素中添加了 type="button" 属性，以确保点击时不会提交表单，提升了可访问性和功能性。

[coderabbitai]

Walkthrough

此次更改涉及 src/BaseInput.tsx 中的 BaseInput 组件，主要是在清除图标的按钮元素上添加了 type="button" 属性，以确保点击时不会提交表单。此更改优化了按钮的行为，增强了可访问性和功能性。组件的其他逻辑和结构保持不变，包括属性处理和条件渲染。

Changes

文件路径	更改摘要
src/BaseInput.tsx	在清除图标的按钮元素中添加 type="button" 属性，确保按钮不提交表单。

Assessment against linked issues

Objective	Addressed	Explanation
Clear button in 1.7.0 accidentally triggers form submits (#82)	✅

Possibly related PRs

• fix: use button tag and native tabindex for clear button #63: 此PR也修改了 BaseInput 组件，通过用 <button> 元素替换清除图标，增强了可访问性，直接与主PR中的 type="button" 属性的添加相关。

🐰 在按钮上加个类型，
清除表单不再有危机，
轻松点击无烦恼，
小兔子乐开怀，
代码清晰又可爱！ 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 8e721a0 and 847688f.

⛔ Files ignored due to path filters (1)

• tests/__snapshots__/index.test.tsx.snap is excluded by !**/*.snap

📒 Files selected for processing (1)

• src/BaseInput.tsx (1 hunks)

🔇 Additional comments (2)

src/BaseInput.tsx (2)

Line range hint 85-98: 事件处理逻辑完善且具有良好的可访问性

按钮的事件处理实现非常完整：

1. 包含了清除操作的回调
2. 通过 onMouseDown 阻止默认行为防止失焦
3. 清晰的类名管理便于样式维护

这些都是很好的实践。

---

84-84: 添加 type="button" 属性修复了表单提交问题

这个改动很好地解决了清除按钮意外触发表单提交的问题。通过明确指定 type="button"，确保了按钮点击时不会导致表单提交。

让我们验证一下代码库中是否还有其他类似的按钮需要添加 type 属性：

✅ Verification successful

代码库中的按钮类型属性设置正确

经过验证，代码库中只有一个 button 元素，位于 BaseInput.tsx 文件中，且已经正确设置了 type="button" 属性。这个改动是完整且正确的，不需要在其他地方进行类似修改。

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 描述：搜索代码库中可能缺少 type 属性的按钮元素

# 使用 ast-grep 搜索不包含 type 属性的 button 元素
ast-grep --pattern 'button {
  $$$
}'

# 使用 ripgrep 搜索 JSX/TSX 文件中的 button 元素
rg -t tsx -t jsx '<button(?![^>]*type=)[^>]*>'

Length of output: 326

---

Script:

#!/bin/bash
# 搜索代码库中的按钮元素，使用修正后的命令

# 使用 ast-grep 搜索 button 元素
ast-grep --pattern '<button>$$$</button>'

# 使用 ast-grep 搜索带属性的 button 元素
ast-grep --pattern '<button $_>$$$</button>'

# 使用 ripgrep 搜索包含 button 的行，带上下文
rg -U --type tsx --type jsx '<button' -B 1 -A 1

Length of output: 168

---

Script:

#!/bin/bash
# 使用更基础的搜索方式查找按钮元素

# 搜索所有包含 button 的文件内容
rg '<button' --type ts --type js --type jsx -B 1 -A 1

# 查找所有 TypeScript 和 JavaScript 文件
fd -e tsx -e ts -e jsx -e js --exec grep -l '<button'

Length of output: 159

---

Script:

#!/bin/bash
# 检查 BaseInput.tsx 文件中的按钮实现

# 显示 BaseInput.tsx 的内容
cat ./src/BaseInput.tsx

# 使用 grep 专门搜索 button 相关的行
grep -A 2 -B 2 '<button' ./src/BaseInput.tsx

Length of output: 5834

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.34%. Comparing base (8e721a0) to head (847688f).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files           5        5           
  Lines         222      222           
  Branches       79       79           
=======================================
  Hits          205      205           
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.