Rename Preferences to Settings#441
Closed
rakleed wants to merge 2 commits intoquoid:masterfrom
rakleed:patch-1
Closed
Rename Preferences to Settings#441rakleed wants to merge 2 commits intoquoid:masterfrom rakleed:patch-1
Preferences to Settings#441rakleed wants to merge 2 commits intoquoid:masterfrom
rakleed:patch-1
Conversation
Collaborator
|
Thank you for your contribution. We should consider the implications of this change:
In contrast, I think that the clearer expression may be more worth changing. |
Owner
I don't think this is high priority but if we wanted to make this change, I also think it makes sense to only change for those on Ventura. We should be able to determine this fairly easily. // Mac-App ViewController.swift
// create outlet for button
@IBOutlet weak var openButton: NSButton
override func viewDidLoad() {
// ...
if #available(macOS 13, *) {
self.openButton.title = "Open Safari Settings"
}
} |
Author
|
@quoid I'm not familiar with the Swift language, so could you please make these changes? |
Owner
|
@rakleed sure 🙂 |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PreferencesbecameSettingsin macOS Ventura: https://9to5mac.com/2022/11/01/mac-system-settings-macos-ventura/