Skip to content

Rename Preferences to Settings#441

Closed
rakleed wants to merge 2 commits intoquoid:masterfrom
rakleed:patch-1
Closed

Rename Preferences to Settings#441
rakleed wants to merge 2 commits intoquoid:masterfrom
rakleed:patch-1

Conversation

@rakleed
Copy link
Copy Markdown

@rakleed rakleed commented Mar 5, 2023

Preferences became Settings in macOS Ventura: https://9to5mac.com/2022/11/01/mac-system-settings-macos-ventura/

@ACTCD
Copy link
Copy Markdown
Collaborator

ACTCD commented Mar 5, 2023

Thank you for your contribution.

We should consider the implications of this change:

  • We still maintain macOS 12 support, this change does not apply to those users
  • Doesn't really affect people's understanding of what the button does
  • The term actually still matches the API of showPreferencesForExtension

In contrast, I think that the clearer expression may be more worth changing.
Maybe like Open Safari Extensions list

@quoid
Copy link
Copy Markdown
Owner

quoid commented Mar 5, 2023

We still maintain macOS 12 support, this change does not apply to those users

I don't think this is high priority but if we wanted to make this change, I also think it makes sense to only change for those on Ventura. We should be able to determine this fairly easily.

// Mac-App ViewController.swift

// create outlet for button
@IBOutlet weak var openButton: NSButton


override func viewDidLoad() {
    // ...
    if #available(macOS 13, *) {
        self.openButton.title = "Open Safari Settings"
    }
}

@rakleed
Copy link
Copy Markdown
Author

rakleed commented Mar 5, 2023

@quoid I'm not familiar with the Swift language, so could you please make these changes?

@quoid
Copy link
Copy Markdown
Owner

quoid commented Mar 5, 2023

@rakleed sure 🙂

@quoid
Copy link
Copy Markdown
Owner

quoid commented Mar 5, 2023

Closing this PR in favor of #442

Thank you for contributing @rakleed

@quoid quoid closed this Mar 5, 2023
@rakleed rakleed deleted the patch-1 branch March 5, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants