Optimize String.prototype.concat#1295
Merged
bnoordhuis merged 1 commit intoquickjs-ng:masterfrom Feb 27, 2026
Merged
Conversation
Optimize the common case where the inputs are strings. Speeds up the string_concat[1-3] benchmarks by 1.1x, 1.8x and 2.1x. Results for string_concat0 are unchanged. It's already so fast there is little to shave off.
bnoordhuis
force-pushed
the
opt-string-p-concat
branch
from
b426828 to
64f0d3c
Compare
saghul
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize the common case where the inputs are strings.
Speeds up the string_concat[1-3] benchmarks by 1.1x, 1.8x and 2.1x.
Results for string_concat0 are unchanged. It's already so fast there
is little to shave off.