Merged
Conversation
…ce to the previous name of this variable. Second, in __init__.py I just added a kwarg to show_grid so that remote mode could be specified in that call.
Contributor
|
Thanks, this is much cleaner. Nice to get some guidance on what's normal for python packaging. I just committed two small fixes. |
richardlin047
added a commit
to richardlin047/modin-spreadsheet
that referenced
this pull request
Feb 3, 2021
* fix: quantopian#315 - filters dont work and poorly displayed * FIX-315: Numerical filter label display * Add basic compatibility with modin. Fails some tests but UI mostly works. The filtering is weird. * Handle empty modin dataframe indexing * Add compatibility with pandas dataframe in addition to modin * Modify filter to work on partial NaN columns * Record all events in widget * Record history of functions applied to dataframe * Record messages sent from client to widget * Add feature to apply transformation history to new df * Try to fix all NaN column filter * Add notebook with working code examples * Create Jupyter cell with df history python code * Add transformation name to and format history code * Ignore active filter for toolbar and add/remove rows * Add clear history API and button * Add handler attr to toolbar button and make button event optional * Add reset filters functionality and button * Add reset sort functionality and button * Move record transformation after transformation completed * Move reset_sort case into function * Add reset_filters API * Move reset all filters command before update sort and table * Change comment * Remove test ipynb * Remove pytest log file * Remove pd_json helper and only use df.to_json * Import pandas as pandas not pd2 * Clean up comments and TODOs * Remove commented code that disables toolbar when filter is active * Format python code with black Co-authored-by: Ofir Yagil <ofir@imubit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the qgrid module into a single directory, splitting inline js and css into a templates directory. This removes the ability to use %install_ext on qgrid, but makes it easier to maintain the package going forward. This PR explicitly does not yet update the example_demo.ipynb file.