Skip to content

deprecate: deprecate fastembed bm25#612

Open
joein wants to merge 1 commit intomainfrom
deprecate-bm25
Open

deprecate: deprecate fastembed bm25#612
joein wants to merge 1 commit intomainfrom
deprecate-bm25

Conversation

@joein
Copy link
Member

@joein joein commented Mar 10, 2026

Qdrant core now has more features than fastembed's implementation, it is recommended to fully switch to Qdrant builtin bm25.

@coderabbitai
Copy link

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 936e2c3e-49f5-434e-916a-8d5709cea797

📥 Commits

Reviewing files that changed from the base of the PR and between 800f388 and 6c4bf2b.

📒 Files selected for processing (1)
  • fastembed/sparse/sparse_text_embedding.py

📝 Walkthrough

Walkthrough

A deprecation warning has been added to the SparseTextEmbedding class initialization to alert users when the "Qdrant/bm25" model is selected (case-insensitive comparison). The warning informs users that this model is deprecated and recommends using the qdrant-client with its Document structure instead. The change preserves existing deprecation logic for other models and does not affect the underlying embedding initialization behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related issues

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding a deprecation for the fastembed BM25 model, which matches the code change that adds a deprecation warning.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for deprecating fastembed's BM25 implementation in favor of Qdrant's built-in version.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch deprecate-bm25

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@joein joein requested a review from tbung March 10, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant