Skip to content

RFR: Enhancement in nox#27

Merged
amolkahat merged 2 commits intopythonpune:masterfrom
digitronik:enhance_nox
Feb 21, 2020
Merged

RFR: Enhancement in nox#27
amolkahat merged 2 commits intopythonpune:masterfrom
digitronik:enhance_nox

Conversation

@digitronik
Copy link
Member

@digitronik digitronik commented Feb 16, 2020

  • Restore cli
  • Parametrize nox over python versions
  • Added pre-commit run with nox
  • Update README

@digitronik digitronik added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 16, 2020
@digitronik digitronik requested a review from akshay196 February 18, 2020 18:38
@digitronik
Copy link
Member Author

digitronik commented Feb 18, 2020

@akshay196 take look.

akshay196
akshay196 reviewed Feb 20, 2020
View reviewed changes
Copy link

@akshay196 akshay196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestion from me:

.github/workflows/main.yml Outdated

- name: Install nox
run: python -m pip install nox
- name: Setup Package and Install Devel Dependancies
Copy link

@akshay196 akshay196 Feb 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix spelling to Dependencies

CONTRIBUTING.md Outdated

# Run unit test with nox
```shell
nox --list # list testing env
Copy link

@akshay196 akshay196 Feb 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[optional] More appropriate comment here is # List all available sessions

@akshay196
Copy link

akshay196 commented Feb 20, 2020

@digitronik Hey. I am not user of pre-commit. Just a question pop up in my mind: what is purpose of providing pre-commit check in nox session? How it is useful for a developer as s/he can directly execute commands pre-commit run -a in his/her shell?

@digitronik
Copy link
Member Author

digitronik commented Feb 20, 2020

@digitronik Hey. I am not user of pre-commit. Just a question pop up in my mind: what is purpose of providing pre-commit check in nox session? How it is useful for a developer as s/he can directly execute commands pre-commit run -a in his/her shell?

Actually, nox session indirectly run by any developer independently. nox just help to s/he for collective operations with respective python env.

if someone run nox only; It will run all sessions one by one including pre-commit.

I can say completely optional.

amolkahat
amolkahat approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@amolkahat amolkahat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@amolkahat amolkahat merged commit 8f6cfd1 into pythonpune:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akshay196 akshay196 akshay196 left review comments

@amolkahat amolkahat amolkahat approved these changes

@raukadah raukadah Awaiting requested review from raukadah

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@digitronik @akshay196 @amolkahat

Comments