fix(dialog): allow selecting both files and folders in add music picker #19
+524
−190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file picker regression only allowed directory selection because open_add_music_dialog used pick_folders(). On macOS, use NSOpenPanel directly with canChooseFiles + canChooseDirectories for native combined selection. On Linux, fall back to pick_files() (GTK limitation). Also fix a latent bug in scan_paths_to_library where scanning a single file would mark every other library track as deleted — the inventory deletion logic compared the filesystem walk against ALL DB fingerprints instead of scoping to the scan paths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keep macOS objc2 dependencies from task-266, drop reverted Linux gtk dependency that was removed from main. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
_loadCacheFromSettings uses only synchronous calls. _fetchLibraryData returns a promise without awaiting it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NSOpenPaneldirectly withcanChooseFiles + canChooseDirectoriesfor native combined file/folder selection — same behavior as Apple Musicpick_files()with audio filters since GTK does not support combined mode (still fixes the regression — waspick_folders()only before)db_fingerprintsare now scoped to the scan paths before the inventory deletion check runsChanges
crates/mt-tauri/Cargo.tomlobjc2,objc2-app-kit,objc2-foundation,dispatch2) — already transitive deps ofrfdcrates/mt-tauri/src/dialog.rsopen_add_music_dialogwith platform-specificNSOpenPanel(macOS) /pick_filesfallback (Linux)crates/mt-tauri/src/scanner/commands.rsscope_fingerprints_to_paths()to prevent out-of-scope tracks from being marked deletedapp/frontend/views/footer.htmldata-testidfor E2E testingapp/frontend/js/stores/library.jsTest plan
🤖 Generated with Claude Code